C++ CodeAnalysis assemblies to v17 #6953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These assemblies have moved and versioned in Visual Studio 2022. Update of the workaround for dotnet#1675 in dotnet#4139.
Member
Author
Forgind
approved these changes
Oct 13, 2021
Contributor
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
I looked through for other instances of 16.0 anywhere and found three examples that we might consider changing:
global.json and MSBuild.sln suggest we should use VS 16.0. I don't think that should hurt, but we may as well update at some point.
eng\CodeAnalysis.ruleset specifies ToolsVersion="16.0". Also doesn't sound like a critical fix.
benvillalobos
approved these changes
Oct 13, 2021
mavasani
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These assemblies have moved and versioned in Visual Studio 2022.
Update of the workaround for #1675 in #4139.
Fixes #6952
Work item (Internal use): AB#1420314
Summary
As a workaround for an assembly load issue, these assemblies must have an explicit codebase in MSBuild.
Customer Impact
Builds that run C++ code analysis can fail with MSBuild internal errors.
Regression?
Yes, against 16.x which had the correct
codeBasefor C++ code analysis assemblies.Testing
Manual testing against repro project from #1675.
Risk
Low. Changes a codebase for an assembly version that should never be referenced to point to the version and location of the extant assembly.
We could further reduce risk by leaving the
16.0.0.0codeBaseentry if that's desired; I don't think it's necessary and I don't know how that assembly could ever get in place in VS2022.