Skip to content

Fix EngineServices version bump check #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2021
Merged

Fix EngineServices version bump check #6939

merged 2 commits into from
Oct 12, 2021

Conversation

@ladipro
Copy link
Member

@ladipro ladipro commented Oct 12, 2021 •
edited
Loading

Context

The check is failing for loc PRs where SYSTEM_PULLREQUEST_TARGETBRANCH is set to refs/head/main because origin/refs/head/main is not a valid revision spec.

Changes Made

Made the script add the origin remote reference only if the branch is not local.

Testing

Tested by this PR and by #6929 after this PR is merged.

@ladipro ladipro merged commit b7c88a3 into dotnet:main Oct 12, 2021
@ladipro ladipro mentioned this pull request Oct 12, 2021
Merged
ladipro added a commit that referenced this pull request Oct 12, 2021
@ladipro
Fix EngineServices version bump check follow-up (#6942)
a5522e6 
### Context

#6939 had a typo and didn't solve the problem with loc PRs.

### Changes Made

Fixed the revision spec prefix to `refs/heads` instead of `refs/head`.

### Testing

This PR and #6929 after this PR is merged.
@dependabot dependabot bot mentioned this pull request Aug 15, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ladipro @rainersigwald