-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[vs16.11] Update dependencies from dotnet/arcade #6688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vs16.11] Update dependencies from dotnet/arcade #6688
Conversation
…708.1 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21358.1
…720.9 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21370.9
…723.8 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21373.8
…727.1 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21377.1
|
@dotnet/kitten, is it OK to merge this given that 16.11 is in QB approval mode? It would piggy-back on the next 16.11 insertion (if any). |
|
@epananth any idea how many more updates will be targeting https://github.com/dotnet/arcade/commits/release/5.0 in the immediate future? Merging an arcade update is a good idea for us long term considering 16.11 is LTS, but going through QB approval is cumbersome. If this is the last (planned) update for a while then I'm fine getting this in with little urgency |
|
I am not sure if this is the last planned update. @riarenas might know better if we have any planned updates. |
|
We don't have anything planned right now for 5.0, a 5.0 arcade update is usually because there's something broken that needed a fix, so it's hard to predict when you might see another one. |
|
Something that most .net repos do for their servicing branches is to set the frequency of their arcade subscriptions to "NONE" and when a new servicing build of the product is about to begin, the subscriptions are manually triggered across the board to make sure the latest fixes are included. |
|
The SDK is aggressive with arcade updates but I suggest maybe msbuild should go to none as suggested for servicing. Note that I would not take this change on its own but only in conjunction with some other 16.11.1 MSBuild fix that we needed (ie I'm not going to QB mode with an infrastructure change) |
That's basically what I was alluding to with piggy-backing on a future 16.11 insertion. If I understand it correctly, you're recommending to merge this into our 16.11 branch and insert only with an actual MSBuild fix if/when there is one. Please let me know if I misunderstood. Thank you! |
IMO this is better than the alternative "when there's a hotfix, remember to manually trigger the Arcade subscription in addition to fixing the hot bug". It means the branch diverges but keeps it ready to go. |
…803.8 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21403.8
We should update our darc subscription, cc @dotnet/kitten |
|
So the conclusion is not to keep merging these and leave the subscription unchanged? That's how I read the last few comments but maybe I am misunderstanding. |
|
I misunderstood the previous comments. I'm on board for not changing the subscription, merging this, and not inserting until we have something worth inserting. |
…809.4 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21409.4
…810.2 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21410.2
This pull request updates the following dependencies
From https://github.com/dotnet/arcade