Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 19, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 82cd8e70-8184-4057-ccfc-08d9301a11ed
  • Build: 20210810.2
  • Date Produced: 8/10/2021 6:42 PM
  • Commit: 9a3b3c3c9609e06f4a350b17274a086b800ca7bf
  • Branch: refs/heads/release/5.0

dotnet-maestro bot added 4 commits July 19, 2021 15:26
…708.1

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21358.1
…720.9

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21370.9
…723.8

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21373.8
…727.1

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21377.1
@ladipro
Copy link
Member

ladipro commented Jul 28, 2021

@dotnet/kitten, is it OK to merge this given that 16.11 is in QB approval mode? It would piggy-back on the next 16.11 insertion (if any).

@benvillalobos
Copy link
Member

@epananth any idea how many more updates will be targeting https://github.com/dotnet/arcade/commits/release/5.0 in the immediate future? Merging an arcade update is a good idea for us long term considering 16.11 is LTS, but going through QB approval is cumbersome.

If this is the last (planned) update for a while then I'm fine getting this in with little urgency

@epananth
Copy link
Member

I am not sure if this is the last planned update. @riarenas might know better if we have any planned updates.

@riarenas
Copy link
Contributor

We don't have anything planned right now for 5.0, a 5.0 arcade update is usually because there's something broken that needed a fix, so it's hard to predict when you might see another one.

@riarenas
Copy link
Contributor

riarenas commented Jul 28, 2021

Something that most .net repos do for their servicing branches is to set the frequency of their arcade subscriptions to "NONE" and when a new servicing build of the product is about to begin, the subscriptions are manually triggered across the board to make sure the latest fixes are included.

@marcpopMSFT
Copy link
Member

The SDK is aggressive with arcade updates but I suggest maybe msbuild should go to none as suggested for servicing. Note that I would not take this change on its own but only in conjunction with some other 16.11.1 MSBuild fix that we needed (ie I'm not going to QB mode with an infrastructure change)

@ladipro
Copy link
Member

ladipro commented Jul 29, 2021

Note that I would not take this change on its own but only in conjunction with some other 16.11.1 MSBuild fix that we needed

That's basically what I was alluding to with piggy-backing on a future 16.11 insertion. If I understand it correctly, you're recommending to merge this into our 16.11 branch and insert only with an actual MSBuild fix if/when there is one. Please let me know if I misunderstood. Thank you!

@rainersigwald
Copy link
Member

merge this into our 16.11 branch and insert only with an actual MSBuild fix if/when there is one

IMO this is better than the alternative "when there's a hotfix, remember to manually trigger the Arcade subscription in addition to fixing the hot bug". It means the branch diverges but keeps it ready to go.

…803.8

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21403.8
@benvillalobos
Copy link
Member

Something that most .net repos do for their servicing branches is to set the frequency of their arcade subscriptions to "NONE" and when a new servicing build of the product is about to begin, the subscriptions are manually triggered across the board to make sure the latest fixes are included.

We should update our darc subscription, cc @dotnet/kitten

@ladipro
Copy link
Member

ladipro commented Aug 4, 2021

So the conclusion is not to keep merging these and leave the subscription unchanged? That's how I read the last few comments but maybe I am misunderstanding.

@benvillalobos
Copy link
Member

I misunderstood the previous comments. I'm on board for not changing the subscription, merging this, and not inserting until we have something worth inserting.

…809.4

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21409.4
dotnet-maestro bot and others added 2 commits August 11, 2021 12:27
…810.2

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21328.3 -> To Version 5.0.0-beta.21410.2
@rainersigwald rainersigwald merged commit bba284c into vs16.11 Aug 30, 2021
@rainersigwald rainersigwald deleted the darc-vs16.11-54a0949b-4ce2-4717-abdc-b8af327a2cbe branch August 30, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants