Ensure project cache initialization happens only once #6569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
changed the title
cdmihai
changed the title
cdmihai
changed the title
rainersigwald
approved these changes
Jun 18, 2021
src/Build/BackEnd/Components/ProjectCache/ProjectCacheService.cs
Outdated
Show resolved
Hide resolved
cdmihai
force-pushed
the
assertCacheStates
branch
from
4814ffb to
13fc8b6
Compare
Forgind
approved these changes
Jun 25, 2021
Forgind
added
the
merge-when-branch-open
To allow asserting service state transition
cdmihai
force-pushed
the
assertCacheStates
branch
from
13fc8b6 to
a365fbf
Compare
This was referenced Jun 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6568. Review that one first. First commit of this PR is Don't launch debugger window for all tests.
Context
Turns out the VS workaround was initializing the plugin on every project query, thus crashing the cache.
Changes Made
Initialization is happening only once now.
ProjectCacheServiceis now asserting that it's always in expected states.Testing
Unit tests.
Notes
Does not affect non project cache code paths so should be no risk for 16.11.