Add SourceBuildManagedOnly to SourceBuild.props #6507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
requested review from
benvillalobos,
crummel,
dseefeld and
rainersigwald
rainersigwald
approved these changes
Jun 1, 2021
dseefeld
approved these changes
Jun 2, 2021
Member
Author
|
@rainersigwald or other msbuild folks, please merge when convenient - thanks. |
Forgind
added
the
merge-when-branch-open
benvillalobos
approved these changes
Jun 2, 2021
Contributor
|
Thanks @MichaelSimons! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#2068
Context
This was something I discovered while trying to consume the Source-Build intermediate package produced by the first ArPow changes made in #6387
Changes Made
Set the
SourceBuildManagedOnlyproperty correctly.How Tested
Verified the resulting
Microsoft.SourceBuild.Intermediate.msbuildpackage is not named rid specific.