Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented May 12, 2021

@mmitche
Copy link
Member Author

mmitche commented May 12, 2021

@rainersigwald
Copy link
Member

@benvillalobos can you fix optprof on that build to check it out?

@benvillalobos
Copy link
Member

@benvillalobos
Copy link
Member

I noticed

<!-- Since this repo isn't on Arcade 6, UseDotNetCertificate is not available. Do the update here instead. -->

We have an arcade 6 update that's ready to merge. Will updating to 6 automagically fix this for us?

@mmitche
Copy link
Member Author

mmitche commented May 12, 2021

I noticed

<!-- Since this repo isn't on Arcade 6, UseDotNetCertificate is not available. Do the update here instead. -->

We have an arcade 6 update that's ready to merge. Will updating to 6 automagically fix this for us?

Just makes it simpler. Let's merge that first and then I can simplify this.

@rainersigwald
Copy link
Member

Let's merge that first and then I can simplify this.

👍🏻 Might be a couple of days because of internal VS branch availability stuff.

Copy link
Contributor

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read comments first (please ignore)

@Forgind
Copy link
Contributor

Forgind commented May 24, 2021

@mmitche, we merged the update to arcade 6 this morning. Sorry for the delay, but you should be good now.

@rainersigwald
Copy link
Member

Note that we're not on latest, so if you need that wait for #6478.

@rainersigwald
Copy link
Member

@mmitche We're on latest Arcade now. Can you do what you wanted (or link explanation so we can)?

@mmitche
Copy link
Member Author

mmitche commented Jun 1, 2021

@mmitche
Copy link
Member Author

mmitche commented Jun 1, 2021

Build looks good

@mmitche
Copy link
Member Author

mmitche commented Jun 2, 2021

@rainersigwald Merge when ready.

@rainersigwald
Copy link
Member

@mmitche even with the "this repo doesn't have UseDotNetCertificate" comment?

@mmitche
Copy link
Member Author

mmitche commented Jun 2, 2021

@rainersigwald Oh cool let me switch over to using that.

@mmitche
Copy link
Member Author

mmitche commented Jun 2, 2021

Attempt using other method: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4826873&view=results

@mmitche
Copy link
Member Author

mmitche commented Jun 2, 2021

Build looks good again.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jun 2, 2021
@rainersigwald
Copy link
Member

Yeah, that build failure is not your fault. Thanks!

@mmitche mmitche merged commit 018bed8 into dotnet:main Jun 2, 2021
@mmitche mmitche deleted the use-dotnet-cert branch June 2, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants