Revert Assembly Loading Performance Changes #6423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. Marked servicing-consider. |
rainersigwald
approved these changes
May 11, 2021
JaynieBai
pushed a commit
that referenced
this pull request
Feb 8, 2023
) Bumps Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.3 to 3.3.4. Release notes Sourced from Microsoft.CodeAnalysis.BannedApiAnalyzers's releases. v3.3.4 Release build of Roslyn-analyzers based on Microsoft.CodeAnalysis 3.3.1 NuGet packages. Works with VS 2019 16.9 or later. Contains important functionality and performance bug fixes on top of v3.3.3 release Commits 22ea642 Merge pull request #6436 from ViktorHofer/patch-1 9018071 Fix buildtransitive vs buildTransitive difference afa5665 [main] Update dependencies from dotnet/arcade (#6423) afee469 Merge pull request #6427 from mavasani/CodeAnalysisTreatWarningsAsErrors_Glob... b858999 Merge pull request #6430 from dotnet/locfiles/be3abf9f-1f22-469b-b26d-7648587... 0cbc3c5 Localized file check-in by OneLocBuild Task: Build definition ID 830: Build I... 113dadc Merge pull request #6429 from dotnet/revert-6364-net7-tests 356147f Revert "Move tests to target .NET 7" 1d7244a Update documentation for CodeAnalysisTreatWarningsAsErrors implementation 6c028d3 Re-implement CodeAnalysisTreatWarningsAsErrors with globalconfig files Additional commits viewable in compare view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When multiple versions of
NuGet.Frameworks.dllget loaded, the first one wins. Since MSBuild depends on this DLL, it means that if someone else loads the DLL first and it doesn't match the version that MSBuild carries, then this breaks MSBuild. The original change was made to improve performance by reducing jitting from the Nuget* DLLs, but it seems that the compatibility tail is too high.This change reverts the assembly loading behavior to its previous state. We can reevaluate options for SDK 6.0.
Fixes #6377.
Customer Impact
MSBuild API consumers that use NuGet references fail. This includes all users of
Microsoft.NET.Test.Sdk.Regression?
Yes. Worked in 16.9, regressed in 16.10 with #6126.
Testing
Manual patching of SDK works with repro project; reversion to prior behavior.
Risk
Low. Reversion to prior behavior.