Changewave 16.10 for restore failures #6372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the behavior improvements from dotnet#6312 to the 16.10 changewave since they cause failures in cases that didn't fail before.
rainersigwald
force-pushed
the
changewave-restore
branch
from
9cddd71 to
ebc4a8b
Compare
rainersigwald
added
the
merge-when-branch-open
Forgind
added a commit
to Forgind/msbuild
that referenced
this pull request
May 10, 2021
Reverts dotnet#6312 and dotnet#6372. SHAs reverted: 29dc5e1 and da900e2 respectively.
Forgind
added a commit
to Forgind/msbuild
that referenced
this pull request
May 10, 2021
Maximal subset of dotnet#6312 and dotnet#6372. Also removes an unnecessary test per dotnet#6430 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6312 made (good, IMO) changes to the behavior of
-restoreand-t:restoreinvocations of MSBuild in malformed projects. Since these are new errors, though, the new behavior might fail passing builds. So put it behind a change wave Just In Case.