Miscellaneous refactors leftover from #5238 #6104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify `#ifdef` logic (across source code) Normalize and Fix namespaces (in Test projects)
benvillalobos
approved these changes
Feb 2, 2021
Forgind
added
the
merge-when-branch-open
Contributor
|
Thanks @Nirmal4G! |
Contributor
|
I just noticed this was pointing to vs16.9. It would've been better pointing at master, but it's a little late for that now. |
Forgind
pushed a commit
that referenced
this pull request
Feb 8, 2021
Simplify `#ifdef` logic (across source code) Normalize and Fix namespaces (in Test projects) authored-by: Nirmal Guru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
Context
While authoring #5238 and other PRs, I did some refactors that have been piling up. I'm upstreaming some of them here.
Changes Made
Simplify
#ifdeflogic (across source code)Normalize and Fix namespaces (in Test projects)
Testing
If existing tests passes then it's A-OK!
Notes
I make sure that these changes are purely cosmetic and doesn't impact any functional changes in the release build.