Skip to content

Traits: This caches values of various environment variables which act… #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdmihai merged 1 commit into from
Jun 14, 2018
Merged

Traits: This caches values of various environment variables which act… #3385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Shared/Traits.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,10 @@ public static Traits Instance
{
get
{
#if DEBUG
if (BuildEnvironmentHelper.Instance.RunningTests && Environment.GetEnvironmentVariable("MSBUILDRELOADTRAITSONEACHACCESS") == "1")
if (BuildEnvironmentHelper.Instance.RunningTests)
{
return new Traits();
}
#endif
return _instance;
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/Shared/UnitTests/TestEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ public static TestEnvironment Create(ITestOutputHelper output = null, bool ignor
env.WithInvariant(new BuildFailureLogInvariant());
}

env.SetEnvironmentVariable("MSBUILDRELOADTRAITSONEACHACCESS", "1");

return env;
}

Expand Down