Ensure *.CopyComplete file gets removed on Clean #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
requested changes
Jan 18, 2018
There was a problem hiding this comment.
Could you instead do this?
<Touch Files="@(CopyUpToDateMarker)"
AlwaysCreate="true"
Condition="'@(ReferencesCopiedInThisBuild)' != ''">
<Output TaskParameter="TouchedFiles" ItemName="FileWritesShareable"/>
</Touch>That is more parallel to the copy task above, and it might be infinitesimally faster to avoid the additional implied item creation below.
There was a problem hiding this comment.
Yes, that is definitely better. BTW, why *Shareable? IIUC, this file should get removed if the project's build outputs are being removed. Please correct me if I'm wrong.
There was a problem hiding this comment.
You're right, use FileWrites, not -Shareable. That naming convention never really sunk in for me and I find it confusing every time I have to think about it.
There was a problem hiding this comment.
For posterity: I was very, very wrong on this: #6917.
The @(CopyUpToDateMarker) file is not added to @(FileWrites), so it gets left behind after a Clean. https://bugzilla.xamarin.com/show_bug.cgi?id=58174 - This is a Xamarin.Android bug, but the same issue is reproducible with regular .net projects too
|
Updated. |
rainersigwald
approved these changes
Jan 19, 2018
AndyGerlicher
approved these changes
Jan 19, 2018
|
Looks good, thanks! |
radical
added a commit
to radical/msbuild
that referenced
this pull request
Jan 30, 2018
The @(CopyUpToDateMarker) file is not added to @(FileWrites), so it gets left behind after a Clean. https://bugzilla.xamarin.com/show_bug.cgi?id=58174 - This is a Xamarin.Android bug, but the same issue is reproducible with regular .net projects too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @(CopyUpToDateMarker) file is not added to @(FileWrites), so it gets
left behind after a Clean.
https://bugzilla.xamarin.com/show_bug.cgi?id=58174
regular .net projects too