Xmldoc fixes

src/Shared/FrameworkLocationHelper.cs

@@ -1515,6 +1515,7 @@ public override string GetPathToDotNetFrameworkSdk(VisualStudioSpec visualStudio
 
             /// <summary>
             /// Gets the full path of reference assemblies folder, which is the full path of .net framework for v1.1 and v2.0.
+            /// </summary>
             public override string GetPathToDotNetFrameworkReferenceAssemblies()
             {
                 return this.GetPathToDotNetFramework(DotNetFrameworkArchitecture.Current);

src/Utilities/ToolLocationHelper.cs

@@ -534,7 +534,7 @@ public static IList<string> GetSDKReferenceFolders(string sdkRoot, string target
         }
 
         /// <summary>
-        /// Add the set of paths for where sdk files should be found. Where <folderType> is redist, references, designtime
+        /// Add the set of paths for where sdk files should be found. Where &lt;folderType&gt; is redist, references, designtime
         /// </summary>
         private static void AddSDKPaths(string sdkRoot, string folderName, string targetConfiguration, string targetArchitecture, List<string> directories)
         {

src/XMakeBuildEngine/BackEnd/Components/RequestBuilder/Lookup.cs

@@ -900,7 +900,7 @@ private ProjectItemInstance RetrieveOriginalFromCloneTable(ProjectItemInstance i
         }
 
         /// <summary>
-        /// Applies a list of modifications to the appropriate ItemDictionary<ProjectItemInstance> in a main table.
+        /// Applies a list of modifications to the appropriate <see cref="ItemDictionary{ProjectItemInstance}" /> in a main table.
         /// If any modifications conflict, these modifications win.
         /// </summary>
         private void ApplyModificationsToTable(ItemDictionary<ProjectItemInstance> table, string itemType, ItemsMetadataUpdateDictionary modify)

src/XMakeBuildEngine/Collections/RetrievableEntryHashSet/HashSet.cs

@@ -47,7 +47,7 @@ namespace Microsoft.Build.Collections
 {
     /// <summary>
     /// Implementation notes:
-    /// This uses an array-based implementation similar to Dictionary<T>, using a buckets array
+    /// This uses an array-based implementation similar to <see cref="Dictionary{T}" />, using a buckets array
     /// to map hash values to the Slots array. Items in the Slots array that hash to the same value
     /// are chained together through the "next" indices. 
     /// 
@@ -249,7 +249,7 @@ internal T this[string name]
         }
 
         /// <summary>
-        /// Add item to this hashset. This is the explicit implementation of the ICollection<T>
+        /// Add item to this hashset. This is the explicit implementation of the <see cref="ICollection{T}" />
         /// interface. The other Add method returns bool indicating whether item was added.
         /// </summary>
         /// <param name="item">item to add</param>

src/XMakeBuildEngine/Evaluation/Conditionals/LessThanExpressionNode.cs

@@ -11,7 +11,7 @@
 namespace Microsoft.Build.Evaluation
 {
     /// <summary>
-    /// Compares for left < right
+    /// Compares for left &lt; right
     /// </summary>
     internal sealed class LessThanExpressionNode : NumericComparisonExpressionNode
     {

src/XMakeBuildEngine/Evaluation/Conditionals/LessThanOrEqualExpressionNode.cs

@@ -11,7 +11,7 @@
 namespace Microsoft.Build.Evaluation
 {
     /// <summary>
-    /// Compares for left <= right
+    /// Compares for left &lt;= right
     /// </summary>
     internal sealed class LessThanOrEqualExpressionNode : NumericComparisonExpressionNode
     {

src/XMakeBuildEngine/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs

@@ -500,7 +500,7 @@ private bool IsVerbosityAtLeast(LoggerVerbosity checkVerbosity)
         /// <summary>
         /// A table indicating if a particular event type should be forwarded
         /// The value is type int rather than bool to avoid the problem of JITting generics.
-        /// Dictionary<string, int> is already compiled into mscorlib.
+        /// <see cref="Dictionary{string, int}" /> is already compiled into mscorlib.
         /// </summary>
         private Dictionary<string, int> _forwardingTable;
 

src/XMakeBuildEngine/Resources/Constants.cs

@@ -152,6 +152,7 @@ internal static class Constants
         /// </summary>
         internal static long assemblyTimestamp;
 
+        /// <summary>
         /// Current version of this MSBuild Engine assembly in the 
         /// form, e.g, "4.0"
         /// </summary>

src/XMakeBuildEngine/UnitTests/BackEnd/Lookup_Tests.cs

@@ -593,6 +593,7 @@ public void KeepMetadataOnlySpecifiedPropagate3()
         /// <summary>
         /// Ensure that once keepOnlySpecified is set to true, it remains in effect, and that if a metadata modification is declared as 'keep value' that
         /// the value as lower scopes is retained.
+        /// </summary>
         [TestMethod]
         public void KeepMetadataOnlySpecifiedPropagate4()
         {

src/XMakeBuildEngine/UnitTests/Definition/ItemDefinitionGroup_Tests.cs

@@ -1215,6 +1215,7 @@ public void DefinitionInImportedFile()
         /// <summary>
         /// Item added to project should pick up the item
         /// definitions that project has.
+        /// </summary>
         [TestMethod]
         public void ProjectAddNewItemPicksUpProjectItemDefinitions()
         {
@@ -1237,6 +1238,7 @@ public void ProjectAddNewItemPicksUpProjectItemDefinitions()
         /// <summary>
         /// Item added to project should pick up the item
         /// definitions that project has.
+        /// </summary>
         [TestMethod]
         public void ProjectAddNewItemExistingGroupPicksUpProjectItemDefinitions()
         {

src/XMakeTasks/AppConfig/AppConfig.cs

@@ -17,7 +17,7 @@ namespace Microsoft.Build.Tasks
     internal sealed class AppConfig
     {
         /// <summary>
-        /// Corresponds to the contents of the <runtime> element.
+        /// Corresponds to the contents of the &lt;runtime&gt; element.
         /// </summary>
         private RuntimeSection _runtime = new RuntimeSection();
 

src/XMakeTasks/AppConfig/BindingRedirect.cs

@@ -9,7 +9,7 @@
 namespace Microsoft.Build.Tasks
 {
     /// <summary>
-    /// Represents a single <bindingRedirect> from the app.config file.
+    /// Represents a single &lt;bindingRedirect&gt; from the app.config file.
     /// </summary>
     internal sealed class BindingRedirect
     {
@@ -56,7 +56,7 @@ internal Version NewVersion
         }
 
         /// <summary>
-        /// The reader is positioned on a <bindingRedirect> element--read it.
+        /// The reader is positioned on a &lt;bindingRedirect&gt; element--read it.
         /// </summary>
         /// <param name="reader"></param>
         internal void Read(XmlTextReader reader)

src/XMakeTasks/AppConfig/DependentAssembly.cs

@@ -12,7 +12,7 @@
 namespace Microsoft.Build.Tasks
 {
     /// <summary>
-    /// Represents a single <dependentassembly> from the app.config file.
+    /// Represents a single &lt;dependentassembly&gt; from the app.config file.
     /// </summary>
     internal sealed class DependentAssembly
     {
@@ -47,7 +47,7 @@ internal AssemblyName PartialAssemblyName
         }
 
         /// <summary>
-        /// The reader is positioned on a <dependentassembly> element--read it.
+        /// The reader is positioned on a &lt;dependentassembly&gt; element--read it.
         /// </summary>
         /// <param name="reader"></param>
         internal void Read(XmlTextReader reader)

src/XMakeTasks/AppConfig/RuntimeSection.cs

@@ -8,7 +8,7 @@
 namespace Microsoft.Build.Tasks
 {
     /// <summary>
-    /// Wraps the <runtime> section of the .config file.
+    /// Wraps the &lt;runtime&gt; section of the .config file.
     /// </summary>
     internal sealed class RuntimeSection
     {
@@ -18,7 +18,7 @@ internal sealed class RuntimeSection
         private ArrayList _dependentAssemblies = new ArrayList();
 
         /// <summary>
-        /// The reader is positioned on a <runtime> element--read it.
+        /// The reader is positioned on a &lt;runtime&gt; element--read it.
         /// </summary>
         /// <param name="reader"></param>
         internal void Read(XmlTextReader reader)

src/XMakeTasks/AssemblyDependency/AssemblyFoldersExResolver.cs

@@ -108,7 +108,7 @@ internal AssemblyFoldersEx AssemblyFoldersExLocations
 
         /// <summary>
         /// Construct.
-        /// </summary
+        /// </summary>
         public AssemblyFoldersExResolver(string searchPathElement, GetAssemblyName getAssemblyName, FileExists fileExists, GetRegistrySubKeyNames getRegistrySubKeyNames, GetRegistrySubKeyDefaultValue getRegistrySubKeyDefaultValue, GetAssemblyRuntimeVersion getRuntimeVersion, OpenBaseKey openBaseKey, Version targetedRuntimeVesion, ProcessorArchitecture targetProcessorArchitecture, bool compareProcessorArchitecture, IBuildEngine buildEngine)
             : base(searchPathElement, getAssemblyName, fileExists, getRuntimeVersion, targetedRuntimeVesion, targetProcessorArchitecture, compareProcessorArchitecture)
         {
@@ -200,7 +200,7 @@ private void LazyInitialize()
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/AssemblyFoldersResolver.cs

@@ -33,7 +33,7 @@ public AssemblyFoldersResolver(string searchPathElement, GetAssemblyName getAsse
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/AssemblyResolution.cs

@@ -40,7 +40,7 @@ internal static class AssemblyResolution
         /// <param name="isPrimaryProjectReference">True if this is a primary reference directly from the project file.</param>
         /// <param name="executableExtensions">The filename extension of the assembly. Must be this or its no match.</param>
         /// <param name="hintPath">This reference's hintpath</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="resolvedSearchPath">Receives the searchPath that the reference was resolved at. Empty if not resolved.</param>
         /// <param name="userRequestedSpecificFile"> This will be true if the user requested a specific file.</param>

src/XMakeTasks/AssemblyDependency/CandidateAssemblyFilesResolver.cs

@@ -41,7 +41,7 @@ public CandidateAssemblyFilesResolver(string[] candidateAssemblyFiles, string se
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/DirectoryResolver.cs

@@ -34,7 +34,7 @@ public DirectoryResolver(string searchPathElement, GetAssemblyName getAssemblyNa
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/FrameworkPathResolver.cs

@@ -44,7 +44,7 @@ public FrameworkPathResolver(string[] frameworkPaths, InstalledAssemblies instal
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/GacResolver.cs

@@ -40,7 +40,7 @@ public GacResolver(System.Reflection.ProcessorArchitecture targetProcessorArchit
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="candidateAssemblyFiles">List of literal assembly file names to be considered when SearchPaths has {CandidateAssemblyFiles}.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>

src/XMakeTasks/AssemblyDependency/HintPathResolver.cs

@@ -34,7 +34,7 @@ public HintPathResolver(string searchPathElement, GetAssemblyName getAssemblyNam
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/RawFilenameResolver.cs

@@ -35,7 +35,7 @@ public RawFilenameResolver(string searchPathElement, GetAssemblyName getAssembly
         /// <param name="wantSpecificVersion">Whether an exact version match is requested.</param>
         /// <param name="executableExtensions">Allowed executable extensions.</param>
         /// <param name="hintPath">The item's hintpath value.</param>
-        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the <AssemblyFolderKey> on the reference in the project.</param>
+        /// <param name="assemblyFolderKey">Like "hklm\Vendor RegKey" as provided to a reference by the &lt;AssemblyFolderKey&gt; on the reference in the project.</param>
         /// <param name="assembliesConsideredAndRejected">Receives the list of locations that this function tried to find the assembly. May be "null".</param>
         /// <param name="foundPath">The path where the file was found.</param>
         /// <param name="userRequestedSpecificFile">Whether or not the user wanted a specific file (for example, HintPath is a request for a specific file)</param>

src/XMakeTasks/AssemblyDependency/Reference.cs

@@ -189,7 +189,7 @@ sealed internal class Reference
         private bool _embedInteropTypes = false;
 
         /// <summary>
-        /// This is the key that was passed in to the reference through the <AssemblyFolderKey> metadata.
+        /// This is the key that was passed in to the reference through the &lt;AssemblyFolderKey&gt; metadata.
         /// </summary>
         private string _assemblyFolderKey = String.Empty;
 
@@ -718,9 +718,9 @@ internal string HintPath
         }
 
         /// <summary>
-        /// This is the key that was passed in to the reference through the <AssemblyFolderKey> metadata.
+        /// This is the key that was passed in to the reference through the &lt;AssemblyFolderKey&gt; metadata.
         /// </summary>
-        /// <value>The <AssemblyFolderKey> value.</value>
+        /// <value>The &lt;AssemblyFolderKey&gt; value.</value>
         internal string AssemblyFolderKey
         {
             get { return _assemblyFolderKey; }