Skip to content

Restrict partial evaluation to ProjectInstance - #14340

Merged
ViktorHofer merged 2 commits into
mainfrom
vihofer/remove-partial-eval-from-project
Jul 13, 2026
Merged

ViktorHofer merged 2 commits into
mainfrom
vihofer/remove-partial-eval-from-project

Address PR review feedback

f64fd1d
Select commit
Loading
Failed to load commit list.
Azure Pipelines / msbuild-quarantine succeeded Jul 13, 2026 in 58m 37s

Build #20260713.22 had test failures

Details

Tests

  • Failed: 27 (3.92%)
  • Passed: 642 (93.18%)
  • Other: 20 (2.90%)
  • Total: 689

Annotations

Check failure on line 1 in Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent(content: "\n <Project>\n "···, placeHolder: "\\**\\*.targets", excludePlaceHolder: null)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-quarantine

Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent(content: "\n <Project>\n "···, placeHolder: "\\**\\*.targets", excludePlaceHolder: null)

Microsoft.Build.Exceptions.InvalidProjectFileException : The imported project "/**/*.targets" was not found. Confirm that the expression in the Import declaration "/**/*.targets", which evaluated to "/**/*.targets", is correct, and that the file exists on disk.  /tmp/xupw3ije.g1t/MSBuildTempg8F94m/Temporarydba9df1687224e7d8388de8fde375940/build.proj
Raw output
   at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject(String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, Object[] args) in /_/src/Shared/ProjectErrorUtilities.cs:line 268
   at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject[T1,T2,T3](IElementLocation elementLocation, String resourceName, T1 arg0, T2 arg1, T3 arg2) in /_/src/Shared/ProjectErrorUtilities.cs:line 78
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImportsFromUnescapedImportExpression(String directoryOfImportingFile, ProjectImportElement importElement, String unescapedExpression, Boolean throwOnFileNotExistsError, List`1& imports) in /_/src/Build/Evaluation/Evaluator.cs:line 2341
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImportsFromUnescapedImportExpressionConditioned(String directoryOfImportingFile, ProjectImportElement importElement, List`1& projects, SdkResult& sdkResult) in /_/src/Build/Evaluation/Evaluator.cs:line 1964
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImports(String directoryOfImportingFile, ProjectImportElement importElement, SdkResult& sdkResult) in /_/src/Build/Evaluation/Evaluator.cs:line 1574
   at Microsoft.Build.Evaluation.Evaluator`4.EvaluateImportElement(String directoryOfImportingFile, ProjectImportElement importElement) in /_/src/Build/Evaluation/Evaluator.cs:line 1454
   at Microsoft.Build.Evaluation.Evaluator`4.PerformDepthFirstPass(ProjectRootElement currentProjectOrImport) in /_/src/Build/Evaluation/Evaluator.cs:line 971
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate() in /_/src/Build/Evaluation/Evaluator.cs:line 684
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate(IEvaluatorData`4 data, Project project, ProjectRootElement root, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ICollection`1 propertiesFromCommandLine, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, IDirectoryCacheFactory directoryCacheFactory, ProjectRootElementCacheBase projectRootElementCache, BuildEventContext buildEventContext, ISdkResolverService sdkResolverService, Int32 submissionId, EvaluationContext evaluationContext, Boolean interactive, ProjectEvaluationStage evaluationStage) in /_/src/Build/Evaluation/Evaluator.cs:line 362
   at Microsoft.Build.Execution.ProjectInstance.Initialize(ProjectRootElement xml, IDictionary`2 globalProperties, String explicitToolsVersion, String explicitSubToolsetVersion, Int32 visualStudioVersionFromSolution, BuildParameters buildParameters, ILoggingService loggingService, BuildEventContext buildEventContext, ISdkResolverService sdkResolverService, Int32 submissionId, Nullable`1 projectLoadSettings, EvaluationContext evaluationContext, IDirectoryCacheFactory directoryCacheFactory, ProjectEvaluationStage evaluationStage) in /_/src/Build/Instance/ProjectInstance.cs:line 3345
   at Microsoft.Build.Execution.ProjectInstance..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, Nullable`1 projectLoadSettings, EvaluationContext evaluationContext, IDirectoryCacheFactory directoryCacheFactory, Boolean interactive, ProjectEvaluationStage evaluationStage) in /_/src/Build/Instance/ProjectInstance.cs:line 328
   at Microsoft.Build.Execution.ProjectInstance.FromFile(String file, ProjectOptions options) in /_/src/Build/Instance/ProjectInstance.cs:line 931
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.CreateProjectInstanceFromFileWithDriveEnumeratingWildcard(TestEnvironment env, String testProjectFile, Boolean throwException) in /mnt/vss/_work/1/s/src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs:line 962
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.CleanContentsAndCreateProjectInstanceFromFileWithDriveEnumeratingWildcard(String content, Boolean throwException) in /mnt/vss/_work/1/s/src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs:line 937
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent(String content, String placeHolder, String excludePlaceHolder) in /mnt/vss/_work/1/s/src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs:line 925
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Build.UnitTests.OM.Definition.ProjectItemWithOptimizations_Tests.LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent(content: "\n <Project>\n "···, placeHolder: "\\**\\*.targets", excludePlaceHolder: null)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-quarantine

Microsoft.Build.UnitTests.OM.Definition.ProjectItemWithOptimizations_Tests.LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent(content: "\n <Project>\n "···, placeHolder: "\\**\\*.targets", excludePlaceHolder: null)

Microsoft.Build.Exceptions.InvalidProjectFileException : The imported project "/**/*.targets" was not found. Confirm that the expression in the Import declaration "/**/*.targets", which evaluated to "/**/*.targets", is correct, and that the file exists on disk.  /tmp/xupw3ije.g1t/MSBuildTempg8F94m/Temporary5c3a0bd4a5794a3a95bddad0953597a7/build.proj
Raw output
   at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject(String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, Object[] args) in /_/src/Shared/ProjectErrorUtilities.cs:line 268
   at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject[T1,T2,T3](IElementLocation elementLocation, String resourceName, T1 arg0, T2 arg1, T3 arg2) in /_/src/Shared/ProjectErrorUtilities.cs:line 78
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImportsFromUnescapedImportExpression(String directoryOfImportingFile, ProjectImportElement importElement, String unescapedExpression, Boolean throwOnFileNotExistsError, List`1& imports) in /_/src/Build/Evaluation/Evaluator.cs:line 2341
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImportsFromUnescapedImportExpressionConditioned(String directoryOfImportingFile, ProjectImportElement importElement, List`1& projects, SdkResult& sdkResult) in /_/src/Build/Evaluation/Evaluator.cs:line 1964
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImports(String directoryOfImportingFile, ProjectImportElement importElement, SdkResult& sdkResult) in /_/src/Build/Evaluation/Evaluator.cs:line 1574
   at Microsoft.Build.Evaluation.Evaluator`4.EvaluateImportElement(String directoryOfImportingFile, ProjectImportElement importElement) in /_/src/Build/Evaluation/Evaluator.cs:line 1454
   at Microsoft.Build.Evaluation.Evaluator`4.PerformDepthFirstPass(ProjectRootElement currentProjectOrImport) in /_/src/Build/Evaluation/Evaluator.cs:line 971
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate() in /_/src/Build/Evaluation/Evaluator.cs:line 684
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate(IEvaluatorData`4 data, Project project, ProjectRootElement root, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ICollection`1 propertiesFromCommandLine, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, IDirectoryCacheFactory directoryCacheFactory, ProjectRootElementCacheBase projectRootElementCache, BuildEventContext buildEventContext, ISdkResolverService sdkResolverService, Int32 submissionId, EvaluationContext evaluationContext, Boolean interactive, ProjectEvaluationStage evaluationStage) in /_/src/Build/Evaluation/Evaluator.cs:line 362
   at Microsoft.Build.Execution.ProjectInstance.Initialize(ProjectRootElement xml, IDictionary`2 globalProperties, String explicitToolsVersion, String explicitSubToolsetVersion, Int32 visualStudioVersionFromSolution, BuildParameters buildParameters, ILoggingService loggingService, BuildEventContext buildEventContext, ISdkResolverService sdkResolverService, Int32 submissionId, Nullable`1 projectLoadSettings, EvaluationContext evaluationContext, IDirectoryCacheFactory directoryCacheFactory, ProjectEvaluationStage evaluationStage) in /_/src/Build/Instance/ProjectInstance.cs:line 3345
   at Microsoft.Build.Execution.ProjectInstance..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, Nullable`1 projectLoadSettings, EvaluationContext evaluationContext, IDirectoryCacheFactory directoryCacheFactory, Boolean interactive, ProjectEvaluationStage evaluationStage) in /_/src/Build/Instance/ProjectInstance.cs:line 328
   at Microsoft.Build.Execution.ProjectInstance.FromFile(String file, ProjectOptions options) in /_/src/Build/Instance/ProjectInstance.cs:line 931
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.CreateProjectInstanceFromFileWithDriveEnumeratingWildcard(TestEnvironment env, String testProjectFile, Boolean throwException) in /mnt/vss/_work/1/s/src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs:line 962
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.CleanContentsAndCreateProjectInstanceFromFileWithDriveEnumeratingWildcard(String content, Boolean throwException) in /mnt/vss/_work/1/s/src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs:line 937
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent(String content, String placeHolder, String excludePlaceHolder) in /mnt/vss/_work/1/s/src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs:line 925
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Build.UnitTests.Preprocessor.Preprocessor_Tests.SdkResolverItemsAndPropertiesAreInPreprocessedOutput

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-quarantine

Microsoft.Build.UnitTests.Preprocessor.Preprocessor_Tests.SdkResolverItemsAndPropertiesAreInPreprocessedOutput

System.InvalidOperationException : Sequence contains no matching element
Raw output
   at System.Linq.ThrowHelper.ThrowNoMatchException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.Build.UnitTests.Preprocessor.Preprocessor_Tests.SdkResolverItemsAndPropertiesAreInPreprocessedOutput() in /mnt/vss/_work/1/s/src/Build.UnitTests/Evaluation/Preprocessor_Tests.cs:line 995
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Build.UnitTests.BackEnd.BuildManager_Tests.GraphBuildCircular

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-quarantine

Microsoft.Build.UnitTests.BackEnd.BuildManager_Tests.GraphBuildCircular

System.ArgumentNullException : Value cannot be null. (Parameter 'dictionary')
Raw output
   at System.ArgumentNullException.Throw(String paramName)
   at System.Collections.ObjectModel.ReadOnlyDictionary`2..ctor(IDictionary`2 dictionary)
   at System.Collections.Generic.CollectionExtensions.AsReadOnly[TKey,TValue](IDictionary`2 dictionary)
   at Microsoft.Build.Graph.GraphBuildRequestData.get_GlobalPropertiesLookup() in /_/src/Build/Graph/GraphBuildRequestData.cs:line 228
   at Microsoft.Build.Execution.BuildManager.ExecuteSubmission[TRequestData,TResultData](BuildSubmissionBase`2 submission, Boolean allowMainThreadBuild) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1685
   at Microsoft.Build.Execution.BuildSubmissionBase`2.ExecuteAsync(BuildSubmissionCompleteCallbackInternal`2 callback, Object context, Boolean allowMainThreadBuild) in /_/src/Build/BackEnd/BuildManager/BuildSubmission.cs:line 75
   at Microsoft.Build.Graph.GraphBuildSubmission.ExecuteAsync(GraphBuildSubmissionCompleteCallback callback, Object context) in /_/src/Build/Graph/GraphBuildSubmission.cs:line 46
   at Microsoft.Build.Graph.GraphBuildSubmission.Execute() in /_/src/Build/Graph/GraphBuildSubmission.cs:line 56
   at Microsoft.Build.Execution.BuildManager.BuildRequest[TRequestData,TResultData](TRequestData requestData) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1019
   at Microsoft.Build.Execution.BuildManager.Build[TRequestData,TResultData](BuildParameters parameters, TRequestData requestData) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1421
   at Microsoft.Build.Execution.BuildManager.Build(BuildParameters parameters, GraphBuildRequestData requestData) in /_/src/Build/BackEnd/BuildManager/BuildManager.cs:line 1450
   at Microsoft.Build.UnitTests.BackEnd.BuildManager_Tests.GraphBuildCircular() in /mnt/vss/_work/1/s/src/Build.UnitTests/BackEnd/BuildManager_Tests.cs:line 4460
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)