Skip to content

Change IsPackable to true and add IsShipping flag - #13924

Merged
ViktorHofer merged 3 commits into
mainfrom
ViktorHofer-patch-2
Jun 2, 2026
Merged

Change IsPackable to true and add IsShipping flag#13924
ViktorHofer merged 3 commits into
mainfrom
ViktorHofer-patch-2

Conversation

@ViktorHofer

Copy link
Copy Markdown
Member

Fixes #

Context

Changes Made

Testing

Notes

Comment thread src/ThreadSafeTaskAnalyzer/ThreadSafeTaskAnalyzer.csproj
@ViktorHofer
ViktorHofer marked this pull request as ready for review June 2, 2026 15:12
Copilot AI review requested due to automatic review settings June 2, 2026 15:12
Comment thread src/ThreadSafeTaskAnalyzer/ThreadSafeTaskAnalyzer.csproj
@ViktorHofer

Copy link
Copy Markdown
Member Author

Here is the layout that this creates:

image

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ThreadSafeTaskAnalyzer project to start producing a NuGet package (for consumption by partner repos) while marking it as non-shipping, and explicitly packs the built analyzer assembly into the NuGet analyzers/dotnet/cs folder.

Changes:

  • Flip IsPackable to true and add IsShipping=false to generate a non-shipping package.
  • Add an explicit Pack="true" item to place the analyzer DLL under analyzers/dotnet/cs/ in the nupkg.
Show a summary per file
File Description
src/ThreadSafeTaskAnalyzer/ThreadSafeTaskAnalyzer.csproj Enables packing and adds explicit analyzer assembly packing path, with a non-shipping flag.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/ThreadSafeTaskAnalyzer/ThreadSafeTaskAnalyzer.csproj

@AR-May AR-May left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ViktorHofer
ViktorHofer enabled auto-merge (squash) June 2, 2026 17:47
@ViktorHofer
ViktorHofer merged commit de9a0e9 into main Jun 2, 2026
10 checks passed
@ViktorHofer
ViktorHofer deleted the ViktorHofer-patch-2 branch June 2, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants