Restore Microsoft.Build binary compatibility for relocated communication types#13805
Closed
Copilot wants to merge 3 commits into
Closed
Restore Microsoft.Build binary compatibility for relocated communication types#13805Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Contributor
|
Hello @copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/f3218ee8-4a20-4398-bd9c-47583a627d43 Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/f3218ee8-4a20-4398-bd9c-47583a627d43 Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MSB4236 SDK-not-found regression for MSBuildLocator
Restore Microsoft.Build binary compatibility for relocated communication types
May 18, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item (Internal use):
Summary
MSB4236 regressions were triggered by relocating communication/XMake types from
Microsoft.BuildtoMicrosoft.Build.Frameworkwithout forwarding legacy type identities. In mixed-load host scenarios (notably MSBuildLocator-based hosts), this can surface as SDK resolver fallthrough andMSB4236.TypeForwardedToentries insrc/Build/AssemblyInfo.csfor:Microsoft.Build.Internal.HandshakeMicrosoft.Build.Internal.HandshakeComponentsMicrosoft.Build.Internal.HandshakeOptionsMicrosoft.Build.Internal.HandshakeStatusMicrosoft.Build.Internal.ServerNodeHandshakeMicrosoft.Build.BackEnd.INodePacketMicrosoft.Build.BackEnd.NodePacketTypeMicrosoft.Build.BackEnd.NodePacketTypeExtensionsMicrosoft.Build.Internal.CommunicationsUtilitiesMicrosoft.Build.Shared.XMakeAttributesMicrosoft.Build.Shared.XMakeElementssrc/Build.UnitTests/BackEnd/TypeForwarding_Tests.csto assert these forwarded identities are present intypeof(BuildManager).Assembly.GetForwardedTypes().Customer Impact
Restores binary compatibility for hosts that still resolve these type tokens against
Microsoft.Build.dll, preventing resolver-chainTypeLoadExceptionpaths that manifest as false SDK-not-found (MSB4236) failures.Regression?
Yes. Introduced when types were moved from
Microsoft.BuildtoMicrosoft.Build.Frameworkwithout matching forwarders.Testing
Added a focused unit test validating that the expected forwarded types are emitted by
Microsoft.Build.Risk
Low. Scope is limited to assembly-level type forwarding metadata and targeted compatibility test coverage.