Skip to content

Skip flaky ToolTaskThatTimeoutAndRetry test on CI #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jankratochvilcz wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Skip flaky ToolTaskThatTimeoutAndRetry test on CI #13668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Utilities.UnitTests/ToolTask_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,6 +1005,7 @@ public void SetsTerminationTimeoutCorrectly(int timeout, bool isInvalidValid)
[InlineData(1, false)]
[InlineData(3, false)]
[InlineData(3, true)]
[SkipOnCI("This test is consistently flaky even after multiple attempts to stabilize it")]
Comment thread
jankratochvilcz marked this conversation as resolved.
public void ToolTaskThatTimeoutAndRetry(int repeats, bool timeoutOnFirstExecution)
Comment on lines +1008 to 1009

Copilot AI Apr 30, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SkipOnCI is only referenced here and isn’t defined anywhere in this repo (no SkipOnCIAttribute implementation under src/). If this attribute isn’t provided by the referenced xUnit packages, this will fail to compile or won’t actually skip on CI. Please either (1) add a SkipOnCIAttribute to the shared test infrastructure (e.g., src/UnitTests.Shared) that checks common CI env vars, or (2) switch to an existing conditional-skip mechanism already used in this repo.

Copilot uses AI. Check for mistakes.
{
using var env = TestEnvironment.Create(_output);
Expand Down
Loading