Skip to content

Retry pipe connection in TryShutdownServer to fix flaky CanShutdownServerProcess test #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huulinhnguyen-dev wants to merge 4 commits into from
Closed

Retry pipe connection in TryShutdownServer to fix flaky CanShutdownServerProcess test #13559

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db4efae
Retry pipe connection in TryShutdownServer to fix flaky CanShutdownSe…
huulinhnguyen-dev Apr 17, 2026
bfe530f
Stabilize CanShutdownServerProcess test: retry pipe connection on shu…
huulinhnguyen-dev Apr 17, 2026
5e41329
Merge branch 'main' into dev/huulinhnguyen/fix-flaky-canshutdownserve…
huulinhnguyen-dev May 6, 2026
ec45928
Stabilize CanShutdownServerProcess(byBuildManager: True) test
huulinhnguyen-dev May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/MSBuild.UnitTests/MSBuildServer_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,16 +253,24 @@ public void CanShutdownServerProcess(bool byBuildManager)

if (byBuildManager)
{
BuildManager.DefaultBuildManager.ShutdownAllNodes();
// ShutdownAllNodes does not expose whether the MSBuildServer was successfully
// contacted. The server may be recycling its pipe right after the build completes
// (busy mutex released before new pipe is ready), causing the first attempt to
// silently fail. Retry until the process exits or a reasonable timeout elapses.
Stopwatch sw = Stopwatch.StartNew();
while (!serverProcess.HasExited && sw.ElapsedMilliseconds < 10_000)
{
BuildManager.DefaultBuildManager.ShutdownAllNodes();
serverProcess.WaitForExit(500);
}
}
else
{
bool serverIsDown = MSBuildClient.ShutdownServer(CancellationToken.None);
serverIsDown.ShouldBeTrue();
serverProcess.WaitForExit(10_000);
}

serverProcess.WaitForExit(10_000);

serverProcess.HasExited.ShouldBeTrue();
}

Expand Down
Loading