Skip to content

Remove duplicate test cases in MultithreadableTaskAnalyzer #13483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 1 commit into from
Apr 2, 2026
Merged

Remove duplicate test cases in MultithreadableTaskAnalyzer #13483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 0 additions & 121 deletions src/ThreadSafeTaskAnalyzer.Tests/MultiThreadableTaskAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,87 +212,6 @@ public override bool Execute()
// MSBuildTask0002: TaskEnvironment required (only for IMultiThreadableTask)
// ═══════════════════════════════════════════════════════════════════════

[Fact]
public async Task EnvironmentGetEnvVar_InMultiThreadableTask_ProducesWarning()
{
var diags = await GetDiagnosticsAsync("""
using System;
using Microsoft.Build.Framework;
public class MyTask : Microsoft.Build.Utilities.Task, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }
public override bool Execute()
{
var val = Environment.GetEnvironmentVariable("PATH");
return true;
}
}
""");

diags.ShouldContain(d => d.Id == DiagnosticIds.TaskEnvironmentRequired);
diags.Length.ShouldBe(1);
}

[Fact]
public async Task EnvironmentSetEnvVar_InMultiThreadableTask_ProducesWarning()
{
var diags = await GetDiagnosticsAsync("""
using System;
using Microsoft.Build.Framework;
public class MyTask : Microsoft.Build.Utilities.Task, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }
public override bool Execute()
{
Environment.SetEnvironmentVariable("KEY", "VALUE");
return true;
}
}
""");

diags.ShouldContain(d => d.Id == DiagnosticIds.TaskEnvironmentRequired);
}

[Fact]
public async Task EnvironmentCurrentDirectory_InMultiThreadableTask_ProducesWarning()
{
var diags = await GetDiagnosticsAsync("""
using System;
using Microsoft.Build.Framework;
public class MyTask : Microsoft.Build.Utilities.Task, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }
public override bool Execute()
{
var dir = Environment.CurrentDirectory;
return true;
}
}
""");

diags.ShouldContain(d => d.Id == DiagnosticIds.TaskEnvironmentRequired);
}

[Fact]
public async Task PathGetFullPath_InMultiThreadableTask_ProducesWarning()
{
var diags = await GetDiagnosticsAsync("""
using System.IO;
using Microsoft.Build.Framework;
public class MyTask : Microsoft.Build.Utilities.Task, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }
public override bool Execute()
{
var p = Path.GetFullPath("relative");
return true;
}
}
""");

diags.ShouldContain(d => d.Id == DiagnosticIds.TaskEnvironmentRequired);
}

[Fact]
public async Task ProcessStart_InMultiThreadableTask_ProducesWarning()
{
Expand Down Expand Up @@ -375,26 +294,6 @@ public override bool Execute()
// MSBuildTask0003: File path requires absolute (only for IMultiThreadableTask)
// ═══════════════════════════════════════════════════════════════════════

[Fact]
public async Task FileExists_WithStringArg_ProducesWarning()
{
var diags = await GetDiagnosticsAsync("""
using System.IO;
using Microsoft.Build.Framework;
public class MyTask : Microsoft.Build.Utilities.Task, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }
public override bool Execute()
{
File.Exists("foo.txt");
return true;
}
}
""");

diags.ShouldContain(d => d.Id == DiagnosticIds.FilePathRequiresAbsolute);
}

[Fact]
public async Task FileReadAllText_WithStringArg_ProducesWarning()
{
Expand Down Expand Up @@ -435,26 +334,6 @@ public override bool Execute()
diags.ShouldContain(d => d.Id == DiagnosticIds.FilePathRequiresAbsolute);
}

[Fact]
public async Task NewFileInfo_WithStringArg_ProducesWarning()
{
var diags = await GetDiagnosticsAsync("""
using System.IO;
using Microsoft.Build.Framework;
public class MyTask : Microsoft.Build.Utilities.Task, IMultiThreadableTask
{
public TaskEnvironment TaskEnvironment { get; set; }
public override bool Execute()
{
var fi = new FileInfo("file.txt");
return true;
}
}
""");

diags.ShouldContain(d => d.Id == DiagnosticIds.FilePathRequiresAbsolute);
}

[Fact]
public async Task NewStreamReader_WithStringArg_ProducesWarning()
{
Expand Down
3 changes: 2 additions & 1 deletion src/ThreadSafeTaskAnalyzer.Tests/MultiThreadableTaskCodeFixProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Threading.Tasks;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp.Testing;
using Microsoft.CodeAnalysis.Testing;
using Xunit;
Expand Down Expand Up @@ -42,7 +43,7 @@ private static CSharpCodeFixTest<MultiThreadableTaskAnalyzer, MultiThreadableTas
DiagnosticIds.FilePathRequiresAbsolute => new DiagnosticResult(DiagnosticDescriptors.FilePathRequiresAbsolute),
DiagnosticIds.PotentialIssue => new DiagnosticResult(DiagnosticDescriptors.PotentialIssue),
DiagnosticIds.TransitiveUnsafeCall => new DiagnosticResult(DiagnosticDescriptors.TransitiveUnsafeCall),
_ => new DiagnosticResult(id, Microsoft.CodeAnalysis.DiagnosticSeverity.Warning),
_ => new DiagnosticResult(id, DiagnosticSeverity.Warning),
};

[Fact]
Expand Down
Loading