Skip to content

Remove wrong review instructinons#13414

Merged
JanProvaznik merged 2 commits intodotnet:mainfrom
JanProvaznik:review-remove-wrong1
Mar 19, 2026
Merged

Remove wrong review instructinons#13414
JanProvaznik merged 2 commits intodotnet:mainfrom
JanProvaznik:review-remove-wrong1

Conversation

@JanProvaznik
Copy link
Copy Markdown
Member

improves review agent
based on #13397

@JanProvaznik JanProvaznik requested a review from a team as a code owner March 18, 2026 17:39
Copilot AI review requested due to automatic review settings March 18, 2026 17:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates internal contributor/reviewer guidance under .github/ by removing/streamlining some instruction sections and revising the “expert reviewer” checklist/rules.

Changes:

  • Removes some markdown sections/whitespace from task/shared-code instruction docs.
  • Rewrites parts of the “Backwards Compatibility” and other review-dimension guidance in expert-reviewer.md.
  • Adds/adjusts guidance bullets (e.g., Microsoft.IO Redist note; updated checklist items and references).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
.github/instructions/tasks.instructions.md Removes a bullet under “Multithreaded Task Migration” and tightens markdown layout.
.github/instructions/shared-code.instructions.md Removes the “Related Documentation” section at the end of the shared-code instructions.
.github/agents/expert-reviewer.md Rewords multiple review-dimension rules/checklists and adds a few new bullets/links.
Comments suppressed due to low confidence (1)

.github/instructions/shared-code.instructions.md:32

  • All other instruction files under .github/instructions/ appear to include a “Related Documentation” section; removing it here makes this file inconsistent and reduces discoverability for contributors. Consider keeping the section (or adding a brief rationale if it’s intentionally omitted).
## Cross-Platform Correctness

* Handle .NET Framework vs .NET Core differences with appropriate `#if` guards.
* Environment variable access patterns differ across platforms — use the shared helpers.


You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@JanProvaznik JanProvaznik merged commit 05668ef into dotnet:main Mar 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants