Skip to content

Simplify vs-insertion pipelines: remove obsolete rel/dX.Y branch logic#13409

Merged
MichalPavlik merged 6 commits intomainfrom
copilot/update-vs-insertion-yml
Mar 20, 2026
Merged

Simplify vs-insertion pipelines: remove obsolete rel/dX.Y branch logic#13409
MichalPavlik merged 6 commits intomainfrom
copilot/update-vs-insertion-yml

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

Context

The VS repo no longer uses rel/dX.Y target branches. All insertions from main and vs* servicing branches should target main in VS. The AutoInsertTargetBranch had a ~30-line conditional mapping each vsX.Yrel/dX.Y that is now dead code.

Changes Made

vs-insertion.yml:

  • Replace AutoInsertTargetBranch conditional chain with value: 'main' — auto always targets main
  • Trim TargetBranch parameter to auto/main/rel/insiders/rel/stable
  • Keep vs* resource trigger (MSBuild still has those branches)
  • Remove obsolete InsertPackagePropsValues conditional for old servicing branches (17.x Microsoft.Build.Engine/Conversion.Core additions, 17.10/17.12/17.14 PackageProps logic)

vs-insertion-experimental.yml:

  • Trim TargetBranch parameter to main/rel/insiders/rel/stable
  • Remove exp/vsX.Y regex detection — auto-triggered builds always target main

Testing

Pipeline YAML only — no code changes.

Notes

The $props array construction is retained even though InsertPackagePropsValues is always unset, in case it's needed for future servicing.

Copilot AI and others added 3 commits March 18, 2026 14:05
… auto always maps to main

Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
…e triggers

Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
@JanProvaznik JanProvaznik marked this pull request as ready for review March 18, 2026 17:41
Copilot AI review requested due to automatic review settings March 18, 2026 17:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the VS insertion pipeline definitions by removing obsolete rel/dX.Y targeting logic now that insertions should no longer map vsX.Y branches to rel/dX.Y branches in VS.

Changes:

  • Hard-code auto insertion target to main and reduce TargetBranch parameter options.
  • Remove legacy InsertPackagePropsValues branch-condition logic in vs-insertion.yml.
  • Remove experimental exp/vsX.Y branch regex detection so auto-triggered experimental insertions always target main.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
azure-pipelines/vs-insertion.yml Simplifies auto target branch selection and removes legacy servicing-branch PackageProps logic.
azure-pipelines/vs-insertion-experimental.yml Reduces target branch options and removes version-detection logic for auto-triggered runs.

You can also share your feedback on Copilot code review. Take the survey.

MichalPavlik and others added 3 commits March 19, 2026 13:54
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@MichalPavlik MichalPavlik merged commit 6e04068 into main Mar 20, 2026
10 checks passed
@MichalPavlik MichalPavlik deleted the copilot/update-vs-insertion-yml branch March 20, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants