Skip to content

Look for apphost when considering node reuse #13368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainersigwald merged 2 commits into from
Mar 11, 2026
Merged

Look for apphost when considering node reuse #13368

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3e982
Look for apphost when considering node reuse
rainersigwald Mar 11, 2026
8daca33
Apply suggestion from @rainersigwald
rainersigwald Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,8 +635,7 @@ internal static int CountActiveNodesWithMode(NodeMode nodeMode)

private static (string expectedProcessName, IList<Process> nodeProcesses) GetPossibleRunningNodes(NodeMode? expectedNodeMode)
{
string msbuildLocation = Constants.MSBuildExecutableName;
var expectedProcessName = Path.GetFileNameWithoutExtension(CurrentHost.GetCurrentHost() ?? msbuildLocation);
var expectedProcessName = Constants.MSBuildExecutableName;
Comment thread
rainersigwald marked this conversation as resolved.
Outdated

Process[] processes;
try
Expand All @@ -651,7 +650,6 @@ private static (string expectedProcessName, IList<Process> nodeProcesses) GetPos
if (expectedNodeMode.HasValue && ChangeWaves.AreFeaturesEnabled(ChangeWaves.Wave18_5))
{
List<Process> filteredProcesses = [];
bool isDotnetProcess = expectedProcessName.Equals(Path.GetFileNameWithoutExtension(Constants.DotnetProcessName), StringComparison.OrdinalIgnoreCase);

foreach (var process in processes)
{
Expand All @@ -668,11 +666,6 @@ private static (string expectedProcessName, IList<Process> nodeProcesses) GetPos
continue;
}

if (isDotnetProcess && !commandLine.Contains("MSBuild.dll", StringComparison.OrdinalIgnoreCase))
{
continue;
}

NodeMode? processNodeMode = NodeModeHelper.ExtractFromCommandLine(commandLine);
if (processNodeMode.HasValue && processNodeMode.Value == expectedNodeMode.Value)
{
Expand Down
Loading