Fix CodeSign.MissingSigningCert for xsd/Update-MSBuildXsds.ps1#13320
Merged
rainersigwald merged 2 commits intomainfrom Mar 3, 2026
Merged
Fix CodeSign.MissingSigningCert for xsd/Update-MSBuildXsds.ps1#13320rainersigwald merged 2 commits intomainfrom
rainersigwald merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores signing coverage for the Update-MSBuildXsds.ps1 script by re-adding it to the ItemsToSign list, fixing CodeSign.MissingSigningCert caused by an earlier change that removed it instead of including it.
Changes:
- Replace a conditional
ItemsToSign Removewith an unconditionalItemsToSign Includeforartifacts\xsd\Update-MSBuildXsds.ps1. - Remove the now-incorrect comment implying the item should be excluded on non-Windows environments.
PR #13175 accidentally replaced the ItemsToSign Include for Update-MSBuildXsds.ps1 with a Remove (which was a no-op since the file was never included by default). This caused CodeSignValidation to flag the file as unsigned. Restore the Include with an Exists() guard so that signing works in the MSBuild official build (where CopyXsds produces the file) and doesn't break in contexts where the file may not exist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JanProvaznik
force-pushed
the
fix/codesign-xsd-ps1
branch
from
12c5ded to
ddaceef
Compare
rainersigwald
approved these changes
Mar 3, 2026
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Member
|
Filed #13323 for the flaky test failure and forcing the merge. |
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #13175 accidentally replaced the
ItemsToSign IncludeforUpdate-MSBuildXsds.ps1with a conditionalRemove, meaning the file was never added to signing. CodeSignValidation then flagged it as unsigned (CodeSign.MissingSigningCert).Change
Restore the original unconditional
Includeineng/Signing.props. The brokenRemove(which was removing an item that was never added) is deleted.Why this is safe
CopyXsdstarget produces the file inartifacts\xsd. TheIncludeensures it gets signed. This is consumed by VS insertion viaCustomScriptExecutionCommandinvs-insertion.yml.dotnet/dotnet): Signing is test/disabled, so theIncludeis harmless.Fixes AB#2787495