Skip to content

Enlighten RAR task #13319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AR-May merged 46 commits into from
May 19, 2026
Merged

Enlighten RAR task #13319

Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
b743044
Make RAR as a service use TaskEnvironment. Make OutOfProcRarClient th…
AR-May Mar 12, 2026
f5caaff
Absolutize RAR task inputs. ReferenceTable should use the task enviro…
AR-May Mar 12, 2026
f090cef
Make resolvers use task environemnt.
AR-May Mar 12, 2026
84ed710
Enlighten GetReferenceAssemblyPaths
AR-May Mar 12, 2026
fdd2f52
Fix tests.
AR-May Mar 12, 2026
b669d97
Set default driver to enlightened tasks.
AR-May Mar 13, 2026
c818294
Merge branch 'main' into enlighten-RAR-2
AR-May Apr 15, 2026
6e770db
Fix bug with sdk paths comparer.
AR-May Apr 15, 2026
161d875
Added AbsolutePath overload for SerializeCache.
AR-May Apr 15, 2026
a7da484
Ensure that resolvers absolutize the inputs. Do not do canonicalizati…
AR-May Apr 15, 2026
f6f5292
Disambiguated the cref to SerializeCache(string, TaskLoggingHelper, b…
AR-May Apr 15, 2026
92f997c
Be defensive and absolutize in AssemblyFoldersFromConfig cache and re…
AR-May Apr 15, 2026
c4653dd
Add comment.
AR-May Apr 15, 2026
77ea94b
defensively assign empty arrays as values if null value is passed.
AR-May Apr 16, 2026
0688f80
Removed the redundant _taskEnvironment field
AR-May Apr 16, 2026
5186ee4
Add tests for the AppConfigFile in RAR
AR-May Apr 16, 2026
347d260
Fix RAR test fixture FileExists.
AR-May Apr 16, 2026
1046cbc
Address null-safety concern.
AR-May Apr 16, 2026
26636a1
Deduplicate code in StateFileBase.
AR-May Apr 16, 2026
04583ae
Address review feedback for tests.
AR-May Apr 16, 2026
289e6da
Place inputs absolutization under a changewave. Canonicalize the path…
AR-May Apr 23, 2026
6979b95
Ensure that canonicalization in AssemblyTableInfo does not throw.
AR-May Apr 23, 2026
74ad0ec
Remove unnecessary GetCanonicalForm in SystemState.cs
AR-May Apr 23, 2026
47bb660
Remove path canonization and thus unnecessary cache in the InstalledS…
AR-May Apr 23, 2026
e246639
Refactor IsFrameworkFile functions.
AR-May Apr 23, 2026
5a9d94e
Defensively absolutize paths from registry.
AR-May Apr 23, 2026
627af67
Refactor the helper methods in RAR task
AR-May Apr 23, 2026
b8295a5
changewave number
JanProvaznik May 4, 2026
afd952d
Remove unnecessary TaskEnvironment = TaskEnvironmentHelper.CreateForT…
JanProvaznik May 4, 2026
80bec33
Merge origin/main and resolve conflicts
JanProvaznik May 4, 2026
4d72a84
Fix stale Wave 18.6 comments to Wave 18.8
JanProvaznik May 4, 2026
797c567
Add ChangeWaves documentation and add more tests.
AR-May May 6, 2026
389a621
Make the canonicalization error message more clear.
AR-May May 6, 2026
95346fb
Minor refactoring
AR-May May 11, 2026
27de13c
Refactor AbsolutePath array conversions.
AR-May May 11, 2026
06bafbf
Localize temporary message.
AR-May May 11, 2026
df7544d
GAC should not work through the TaskEnvironment.
AR-May May 11, 2026
ec60559
Fix empty paths handling in resolvers.
AR-May May 11, 2026
8db2cd0
Fix race condition in Strings.Initialize
AR-May May 11, 2026
e814358
Revert fixes for OOP RAR client support in MT mode, and add a clear e…
AR-May May 11, 2026
4db964f
Remove redundant TaskEnvironmentHelper.CreateForTest()
AR-May May 11, 2026
cf673f8
Address pr comments: minor refactorings.
AR-May May 12, 2026
1fa6f6d
Use public API for setting default TaskEnvironment.
AR-May May 13, 2026
2f8ee2c
Fix race condition in SystemState.
AR-May May 13, 2026
cc8e522
Merge branch 'main' into enlighten-RAR-2
AR-May May 13, 2026
1787f42
Drop wave gate for empty-path handling in RAR resolvers. Remove tests.
AR-May May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Framework/ChangeWaves.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ internal static class ChangeWaves
internal static readonly Version Wave18_5 = new Version(18, 5);
internal static readonly Version Wave18_6 = new Version(18, 6);
internal static readonly Version Wave18_7 = new Version(18, 7);
internal static readonly Version[] AllWaves = [Wave17_10, Wave17_12, Wave17_14, Wave18_3, Wave18_4, Wave18_5, Wave18_6, Wave18_7];
internal static readonly Version Wave18_8 = new Version(18, 8);
internal static readonly Version[] AllWaves = [Wave17_10, Wave17_12, Wave17_14, Wave18_3, Wave18_4, Wave18_5, Wave18_6, Wave18_7, Wave18_8];
Comment thread
AR-May marked this conversation as resolved.

/// <summary>
/// Special value indicating that all features behind all Change Waves should be enabled.
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks.UnitTests/AssemblyDependency/AssemblyFoldersFromConfig_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.IO;
Expand Down
35 changes: 22 additions & 13 deletions src/Tasks.UnitTests/AssemblyDependency/GlobalAssemblyCacheTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void VerifySimpleNamev2057020()
AssemblyNameExtension fusionName = new AssemblyNameExtension("System");


string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("2.0.57027"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, false);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("2.0.57027"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, false, TaskEnvironmentHelper.CreateForTest());
Assert.NotNull(path);
Assert.Equal(system2Path, path);
}
Expand All @@ -81,7 +81,7 @@ public void VerifySimpleNamev2057020SpecificVersion()
AssemblyNameExtension fusionName = new AssemblyNameExtension("System");


string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("2.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("2.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true, TaskEnvironmentHelper.CreateForTest());
Assert.NotNull(path);
Assert.Equal(system4Path, path);
}
Expand All @@ -104,7 +104,7 @@ public void VerifyFusionNamev2057020SpecificVersion()
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, Version=2.0.0.0");


string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("2.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("2.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true, TaskEnvironmentHelper.CreateForTest());
Assert.NotNull(path);
Assert.Equal(system2Path, path);
}
Expand All @@ -127,7 +127,7 @@ public void VerifySimpleNamev40()
AssemblyNameExtension fusionName = new AssemblyNameExtension("System");


string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("4.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, false);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("4.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, false, TaskEnvironmentHelper.CreateForTest());
Assert.NotNull(path);
Assert.Equal(system4Path, path);
}
Expand All @@ -151,7 +151,7 @@ public void VerifySimpleNamev40SpecificVersion()
AssemblyNameExtension fusionName = new AssemblyNameExtension("System");


string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("4.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("4.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true, TaskEnvironmentHelper.CreateForTest());
Assert.NotNull(path);
Assert.Equal(system4Path, path);
}
Expand All @@ -172,7 +172,7 @@ public void VerifyFusionNamev40SpecificVersion()
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, Version=4.0.0.0");


string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("4.0.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, _runtimeVersion, new Version("4.0.0.0"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true, TaskEnvironmentHelper.CreateForTest());
Assert.NotNull(path);
Assert.Equal(system4Path, path);
}
Expand All @@ -186,7 +186,7 @@ public void VerifyEmptyPublicKeyspecificVersion()
Assert.Throws<FileLoadException>(() =>
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true, TaskEnvironmentHelper.CreateForTest());
});
}

Expand All @@ -197,7 +197,7 @@ public void VerifyEmptyPublicKeyspecificVersion()
public void VerifyNullPublicKey()
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=null");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, false);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, false, TaskEnvironmentHelper.CreateForTest());
Assert.Null(path);
}

Expand All @@ -208,7 +208,7 @@ public void VerifyNullPublicKey()
public void VerifyNullPublicKeyspecificVersion()
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=null");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.None, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, _gacEnumerator, true, TaskEnvironmentHelper.CreateForTest());
Assert.Null(path);
}

Expand All @@ -221,7 +221,7 @@ public void VerifyNullPublicKeyspecificVersion()
public void VerifyProcessorArchitectureDoesNotCrash()
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=b77a5c561934e089, ProcessorArchitecture=MSIL");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, false);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, false, TaskEnvironmentHelper.CreateForTest());
Assert.Null(path);
}

Expand All @@ -233,7 +233,7 @@ public void VerifyProcessorArchitectureDoesNotCrash()
public void VerifyProcessorArchitectureDoesNotCrashSpecificVersion()
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=b77a5c561934e089, ProcessorArchitecture=MSIL");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), false, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, true, TaskEnvironmentHelper.CreateForTest());
Assert.Null(path);
}

Expand All @@ -245,7 +245,7 @@ public void VerifyProcessorArchitectureDoesNotCrashSpecificVersion()
public void VerifyProcessorArchitectureDoesNotCrashFullFusionName()
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=b77a5c561934e089, ProcessorArchitecture=MSIL");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), true, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, false);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), true, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, false, TaskEnvironmentHelper.CreateForTest());
Assert.Null(path);
}

Expand All @@ -257,7 +257,7 @@ public void VerifyProcessorArchitectureDoesNotCrashFullFusionName()
public void VerifyProcessorArchitectureDoesNotCrashFullFusionNameSpecificVersion()
{
AssemblyNameExtension fusionName = new AssemblyNameExtension("System, PublicKeyToken=b77a5c561934e089, ProcessorArchitecture=MSIL");
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), true, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, true);
string path = GlobalAssemblyCache.GetLocation(fusionName, SystemProcessorArchitecture.MSIL, getRuntimeVersion, new Version("2.0.50727"), true, new FileExists(MockFileExists), _getPathFromFusionName, null /* use the real gac enumerator*/, true, TaskEnvironmentHelper.CreateForTest());
Assert.Null(path);
}

Expand All @@ -271,6 +271,7 @@ public void SystemRuntimeDepends_No_Build()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -340,6 +341,7 @@ public void SystemRuntimeDepends_Yes()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -407,6 +409,7 @@ public void SystemRuntimeDepends_Yes_Indirect()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -473,6 +476,7 @@ public void SystemRuntimeDepends_Yes_Indirect_ExternallyResolved()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -537,6 +541,7 @@ public void NETStandardDepends_Yes()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -601,6 +606,7 @@ public void NETStandardDepends_Yes_Indirect()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -666,6 +672,7 @@ public void NETStandardDepends_Yes_Indirect_ExternallyResolved()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -731,6 +738,7 @@ public void DependsOn_NETStandard_and_SystemRuntime()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();

t.Assemblies = new ITaskItem[]
{
Expand Down Expand Up @@ -799,6 +807,7 @@ public void DependsOn_NETStandard_and_SystemRuntime_ExternallyResolved()
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);
t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
Comment thread
AR-May marked this conversation as resolved.
Outdated

t.Assemblies = new ITaskItem[]
{
Expand Down
53 changes: 43 additions & 10 deletions src/Tasks.UnitTests/AssemblyDependency/Miscellaneous.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,23 +1135,56 @@ public void Regress286699_InvalidSearchPath()
}

/// <summary>
/// Invalid app.config path should not crash.
/// Invalid or empty app.config paths should not crash.
/// Invalid path "|" causes a logged error and task failure.
/// Empty string is silently ignored (Wave18_8 behavior) and task succeeds.
/// </summary>
[Fact]
public void Regress286699_InvalidAppConfig()
[Theory]
[InlineData("|", false)]
[InlineData("", true)]
public void InvalidOrEmptyAppConfig_DoesNotCrash(string appConfigFile, bool expectedSuccess)
{
ResolveAssemblyReference t = new ResolveAssemblyReference();

t.BuildEngine = new MockEngine(_output);

t.Assemblies = new ITaskItem[] { new TaskItem("mscorlib") };
t.AppConfigFile = "|";
t.Assemblies = [new TaskItem("mscorlib")];
t.AppConfigFile = appConfigFile;

bool retval = Execute(t);

Assert.False(retval);
retval.ShouldBe(expectedSuccess);
}

// Should not crash.
/// <summary>
/// When Wave18_8 is disabled, empty AppConfigFile should cause the task to fail
/// with an error, preserving backward-compatible behavior.
/// </summary>
[Fact]
public void EmptyAppConfigFile_Wave18_8_Disabled_Fails()
Comment thread
AR-May marked this conversation as resolved.
{
try
{
using TestEnvironment env = TestEnvironment.Create(_output);

ChangeWaves.ResetStateForTests();
env.SetEnvironmentVariable("MSBUILDDISABLEFEATURESFROMVERSION", ChangeWaves.Wave18_8.ToString());
BuildEnvironmentHelper.ResetInstance_ForUnitTestsOnly();

ResolveAssemblyReference t = new ResolveAssemblyReference();

MockEngine engine = new MockEngine(_output);
t.BuildEngine = engine;
t.Assemblies = new ITaskItem[] { new TaskItem("mscorlib") };
t.AppConfigFile = string.Empty;

bool retval = Execute(t);
retval.ShouldBeFalse();
engine.Errors.ShouldBe(1);
}
finally
{
ChangeWaves.ResetStateForTests();
}
}

/// <summary>
Expand Down Expand Up @@ -6702,7 +6735,7 @@ public void ReferenceTableDependentItemsInDenyList4()
#if FEATURE_WIN32_REGISTRY
null, null, null,
#endif
null, null, null, new Version("4.0"), null, null, null, true, false, null, null, false, null, WarnOrErrorOnTargetArchitectureMismatchBehavior.None, false, false, null, Array.Empty<string>());
null, null, null, new Version("4.0"), null, null, null, true, false, null, null, false, null, WarnOrErrorOnTargetArchitectureMismatchBehavior.None, false, false, null, Array.Empty<string>(), TaskEnvironmentHelper.CreateForTest());
MockEngine mockEngine;
ResolveAssemblyReference rar;
Dictionary<string, string> denyList;
Expand Down Expand Up @@ -6880,7 +6913,7 @@ private static ReferenceTable MakeEmptyReferenceTable(TaskLoggingHelper log)
#if FEATURE_WIN32_REGISTRY
null, null, null,
#endif
null, null, new Version("4.0"), null, log, null, true, false, null, null, false, null, WarnOrErrorOnTargetArchitectureMismatchBehavior.None, false, false, null, Array.Empty<string>());
null, null, new Version("4.0"), null, log, null, true, false, null, null, false, null, WarnOrErrorOnTargetArchitectureMismatchBehavior.None, false, false, null, Array.Empty<string>(), TaskEnvironmentHelper.CreateForTest());
return referenceTable;
}

Expand Down
20 changes: 0 additions & 20 deletions src/Tasks.UnitTests/AssemblyDependency/Node/RarNodeExecuteRequest_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,6 @@ public void TaskInputsArePropagated()
Assert.Equal(clientRar.StateFile, nodeRar.StateFile);
}

[Fact]
public void KnownRelativePathsAreResolvedToFullPaths()
{
const string AppConfigFileName = "App.config";
const string StateFileName = "AssemblyReference.cache";
ResolveAssemblyReference clientRar = new()
{
BuildEngine = new MockEngine(),
AppConfigFile = AppConfigFileName,
StateFile = StateFileName,
};
RarNodeExecuteRequest request = new(clientRar);

ResolveAssemblyReference nodeRar = new();
request.SetTaskInputs(nodeRar, CreateBuildEngine());

Assert.Equal(Path.GetFullPath(AppConfigFileName), nodeRar.AppConfigFile);
Assert.Equal(Path.GetFullPath(StateFileName), nodeRar.StateFile);
}

[Fact]
public void BuildEngineSettingsArePropagated()
{
Expand Down
Loading
Loading