Only get command line args names on modern .NET#13314
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Disables process command-line retrieval on .NET Framework builds to avoid a Visual Studio performance regression (extra assembly loads), while keeping the behavior available on modern .NET.
Changes:
- On non-
NETbuilds,ProcessExtensions.TryGetCommandLinenow intentionally returnstruewithcommandLine == nullinstead of performing WMI/COM command line retrieval. - Restricts
TryGetCommandLineunit tests to modern .NET by switching them to[DotNetOnlyFact].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Shared/ProcessExtensions.cs | Avoids WMI/COM command line retrieval on .NET Framework builds by treating command line retrieval as “unsupported” (null command line). |
| src/Utilities.UnitTests/ProcessExtensions_Tests.cs | Marks command line retrieval tests as .NET-only to align with disabled netfx behavior. |
rainersigwald
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a reported VS perf regression in assembly loads by just...not doing the feature from #13256 on framework builds of MSBuild.