Improve cross-platform node discovery for reuse with NodeMode filtering#13256

Merged

baronfel merged 34 commits intomainfrom

copilot/improve-node-discovery-for-msbuild

Feb 25, 2026

Commits on Feb 18, 2026

Add cross-platform process command line retrieval and improved node discovery

Copilot
and
baronfel
committed
Fix build errors - add nullable disable and internal test methods

Copilot
and
baronfel
committed
Address code review feedback - fix encoding and race conditions

Copilot
and
baronfel
committed
Improve code clarity with better variable names

Copilot
and
baronfel
committed
Implement Windows command line retrieval for .NET Core and use regex for parsing

Copilot
and
baronfel
committed
Simplify UNICODE_STRING buffer offset calculation with clear comments

Copilot
and
baronfel
committed
Add macOS support for process command line retrieval using sysctl

Copilot
and
baronfel
committed
Remove NodeMode_Tests.cs per review feedback

Copilot
and
baronfel
committed
Enable nullable, fix resource leaks, optimize regex, and remove trivial tests

Copilot
and
baronfel
committed
Add macOS-specific test and OSXOnlyFact attribute, remove Process disposal

Copilot
and
baronfel
committed
Remove dotnet process expansion and use P/Invoke for all Windows builds

Copilot
and
baronfel
committed
Add MSBuild.dll filtering for dotnet processes

Copilot
and
baronfel
committed
Fix macOS KERN_PROCARGS2 buffer parsing to skip padding nulls

Copilot
and
baronfel
committed
refactor native invocations a bit using LibraryImport instead of DllImport
baronfel
committed
Address review feedback: regex source gen, MacOSOnlyFact, change wave, logging, TOCTOU fix

authored and
baronfel
committed
add span-based nodemode parser method
baronfel
committed
add string nodemode detection to regex, make it generated, and share it across both locations that tried to parse node modes
baronfel
committed
minimize diffs
baronfel
committed
Create Wave18_6 and use it for node discovery feature

authored and
baronfel
committed
Fix build error and optimize regex: add missing semicolon, extract pattern constant, use ValueSpan

authored and
baronfel
committed
Add comprehensive trace logging for node discovery filtering

Copilot
and
baronfel
committed
Support fallback on BSD systems
baronfel
committed
Return to basics because I am bad at low-level marshalling
baronfel
committed
support checking for target process architecture
baronfel
committed

Commits on Feb 23, 2026

Commits on Feb 24, 2026

Address feedback from @AR-May
baronfel
committed

Commits on Feb 25, 2026

Re-add KillTree test per review feedback

Copilot
and
baronfel
committed