Skip to content

add multithreaded task migration agent skill#13131

Merged
JanProvaznik merged 3 commits intodotnet:mainfrom
JanProvaznik:taskmigration-skil
Jan 29, 2026
Merged

add multithreaded task migration agent skill#13131
JanProvaznik merged 3 commits intodotnet:mainfrom
JanProvaznik:taskmigration-skil

Conversation

@JanProvaznik
Copy link
Copy Markdown
Member

Context

extracting docs and learnings from migration of copy for the agent to consume

@JanProvaznik JanProvaznik requested a review from a team as a code owner January 28, 2026 11:23
Copilot AI review requested due to automatic review settings January 28, 2026 11:23
@JanProvaznik JanProvaznik changed the title add multithreaded task migration skill add multithreaded task migration agent skill Jan 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for migrating MSBuild tasks to support multithreaded execution. The documentation is structured as a skill guide that explains how to implement IMultiThreadableTask and use TaskEnvironment APIs to avoid global process state issues.

Changes:

  • Adds a new skill document (.github/skills/multithreaded-task-migration/SKILL.md) that provides step-by-step migration guidance
  • Documents the MSBuild multithreaded API including attribute usage, path resolution, environment variables, and process spawning
  • Includes practical examples, test patterns, and a checklist for ensuring thread-safe task implementations

@JanProvaznik JanProvaznik self-assigned this Jan 28, 2026
@AR-May
Copy link
Copy Markdown
Member

AR-May commented Jan 28, 2026

Oh, forgot to add to my review - I noticed that copilot quite often does unnecessary switch from AbsolutePath to string. This leads to us moving between "string" and "AbsolutePath". It would be good if we tell it to try to stay in the "AbsolutePath" world as much as possible, so far as it does not hurt the edge cases.

@JanProvaznik JanProvaznik enabled auto-merge (squash) January 29, 2026 09:17
@JanProvaznik
Copy link
Copy Markdown
Member Author

merging now to have the baseline skill, if you run into something that copilot does wrong, ask it to add the lesson learned to the skill

@JanProvaznik JanProvaznik merged commit 27296fe into dotnet:main Jan 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants