Skip to content

Backflow 10.0.2xx VMR#13121

Merged
ViktorHofer merged 2 commits into
vs18.3from
dkurepa/UnblockBackflows
Jan 28, 2026
Merged

Backflow 10.0.2xx VMR#13121
ViktorHofer merged 2 commits into
vs18.3from
dkurepa/UnblockBackflows

Conversation

@dkurepa

@dkurepa dkurepa commented Jan 26, 2026

Copy link
Copy Markdown
Member

This branch changed which VMR branch was backflowing into it, requiring manual intervention.
This was done using the --unsafe option in darc so please review carefully

@dkurepa
dkurepa requested a review from a team as a code owner January 26, 2026 16:36
Copilot AI review requested due to automatic review settings January 26, 2026 16:36
@ViktorHofer
ViktorHofer enabled auto-merge (squash) January 26, 2026 16:38
@dkurepa

dkurepa commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

oh I didn't save the file, thanks @ViktorHofer

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a VMR (Virtual Monolithic Repository) backflow from a different branch into the 10.0.2xx branch. The operation required the --unsafe option in darc, indicating manual intervention was needed during the merge process. Unfortunately, the merge was not completed successfully, leaving unresolved conflicts.

Changes:

  • Updated VMR source reference with new SHA (181f8798913e9c234e19756db58f38a8cac176ea) and BarId (298730)
  • Added new C# analyzer rules IDE0370 and IDE0380 to .editorconfig
  • Attempted version prefix update with unresolved merge conflict between 18.3.1 and 18.3.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/Version.Details.xml Updates VMR source SHA and BarId for the backflow operation
eng/Versions.props Contains unresolved merge conflict markers for VersionPrefix property
.editorconfig Adds new diagnostic rules IDE0370 and IDE0380, but creates duplicate IDE0370 definition

Comment thread .editorconfig
@dkurepa

dkurepa commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

@rainersigwald could we please get an approval here? this will unblock the backflows to this branch

@ViktorHofer
ViktorHofer merged commit 6111265 into vs18.3 Jan 28, 2026
11 checks passed
@ViktorHofer
ViktorHofer deleted the dkurepa/UnblockBackflows branch January 28, 2026 10:35
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants