Skip to content

Limit extended flag usage to NET and CLR4 runtimes #13080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuliiaKovalova merged 4 commits into from
Jan 21, 2026
+3 −1
Merged

Limit extended flag usage to NET and CLR4 runtimes #13080

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc16f9e
Update TryCreateExtendedHeaderType to check multiple flags
YuliiaKovalova Jan 21, 2026
3426d99
Clarify extended header support conditions
YuliiaKovalova Jan 21, 2026
ea441f6
Update src/Shared/INodePacket.cs
YuliiaKovalova Jan 21, 2026
9a21791
fix the comment
YuliiaKovalova Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Shared/INodePacket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,10 @@ internal static class NodePacketTypeExtensions
/// <returns>True if extended header flag was set, false otherwise.</returns>
public static bool TryCreateExtendedHeaderType(HandshakeOptions handshakeOptions, NodePacketType type, out byte extendedheader)
{
if (Handshake.IsHandshakeOptionEnabled(handshakeOptions, HandshakeOptions.TaskHost))
// Extended headers are supported by all task hosts except CLR2. CLR4 is represented
// by the absence of both CLR2 and NET flags; NET covers .NET Core and later.
if (handshakeOptions.HasFlag(HandshakeOptions.TaskHost)
&& !handshakeOptions.HasFlag(HandshakeOptions.CLR2))
{
extendedheader = (byte)((byte)type | ExtendedHeaderFlag);
return true;
Expand Down
Loading