Skip to content

Log SDK environment variable messages only when values differ #12918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baronfel merged 5 commits into from
Jan 5, 2026
Merged

Log SDK environment variable messages only when values differ #12918

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e33c58
Initial plan
Copilot Dec 11, 2025
20ba4f9
Remove duplicated SDK environment variable log messages
Copilot Dec 11, 2025
743e2d2
Remove unused SDK environment variable string resources
Copilot Dec 11, 2025
6571644
Only log SDK environment variable messages when values differ
Copilot Dec 29, 2025
82fe9b2
Refactor duplicate code into helper method
Copilot Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Build/Instance/ProjectInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,13 +1390,11 @@ public void AddSdkResolvedEnvironmentVariable(string name, string value)
// If the property has already been set as an environment variable, we do not overwrite it.
if (_environmentVariableProperties.Contains(name))
{
_loggingContext.LogComment(MessageImportance.Low, "SdkEnvironmentVariableAlreadySet", name, value);
Comment thread
YuliiaKovalova marked this conversation as resolved.
return;
}
// If another SDK already set it, we do not overwrite it.
else if (_sdkResolvedEnvironmentVariableProperties?.Contains(name) == true)
{
_loggingContext.LogComment(MessageImportance.Low, "SdkEnvironmentVariableAlreadySetBySdk", name, value);
return;
}

Expand All @@ -1412,8 +1410,6 @@ public void AddSdkResolvedEnvironmentVariable(string name, string value)
((IEvaluatorData<ProjectPropertyInstance, ProjectItemInstance, ProjectMetadataInstance, ProjectItemDefinitionInstance>)this)
.SetProperty(name, value, isGlobalProperty: false, mayBeReserved: false, loggingContext: _loggingContext, isEnvironmentVariable: true, isCommandLineProperty: false);
}

_loggingContext.LogComment(MessageImportance.Low, "SdkEnvironmentVariableSet", name, value);
Comment thread
YuliiaKovalova marked this conversation as resolved.
}

/// <summary>
Expand Down