Skip to content

Add information about binlog to stdout #12638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michalbrabec wants to merge 2 commits into from
Closed

Add information about binlog to stdout #12638

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20eceb5
Add information about binlog to stdout
Oct 14, 2025
07f7da1
Merge branch 'main' into 12261-consider-adding-a-message-indicating-b…
michalbrabec Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Build/Logging/BinaryLogger/BinaryLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@ private void LogInitialInfo()
{
LogMessage("BinLogFilePath=" + FilePath);
LogMessage("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name);
Console.WriteLine("BinLogFilePath=" + FilePath);
Console.WriteLine("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name);

@KirillOsenkov KirillOsenkov Oct 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do people need the culture?

As for the binlog, should this be a human readable string? perhaps "Written {0}" or something

@michalbrabec michalbrabec Oct 16, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the culture is needed, I wanted to replicate the message, but I definitely want to make the text localizable and respect the verbosity. This was just a first draft.

}

private void LogMessage(string text)
Expand Down