Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 1, 2025

Fixes part of #12486, but not all.

Context

This introduces a new Terminal Logger Parameter (DISABLENODEDISPLAY) that disables the live-updating node display portion of the Terminal Logger output. This output is very wasteful when LLMs are running the build, and the hope is that we can toggle this flag automatically at the dotnet CLI level to maintain the structure benefits of TL while also not flooding the context.

Changes Made

  • introduced a new parameter and threaded it through the logic

Testing

  • Manual testing done - verified that the flag does in fact disable the display entirely.
tl-node-display-disable.mp4

Notes

This will use the logic from dotnet/sdk#51054 in the SDK to turn off the live-update feature.

@baronfel baronfel requested a review from a team as a code owner October 1, 2025 14:36
@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

@AR-May @rainersigwald here's the backport to 18 - mind reviewing? Then I'll send Tactics mail

@rainersigwald rainersigwald force-pushed the backport/pr-12581-to-vs18.0 branch from 02677d6 to fed2494 Compare October 1, 2025 15:24
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complaining about the version number was an automation false positive, reverted that.

@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

approved over email, needs VS QB now

@baronfel baronfel added this to the .NET 10 milestone Oct 1, 2025
@rainersigwald
Copy link
Member

@AR-May let's merge this and then the 18.0 final branding and prepare a VS insertion.

@YuliiaKovalova YuliiaKovalova merged commit dc755eb into vs18.0 Oct 2, 2025
8 of 10 checks passed
@YuliiaKovalova YuliiaKovalova deleted the backport/pr-12581-to-vs18.0 branch October 2, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants