Optimize for single capture case#12569
Merged
JanProvaznik merged 2 commits intodotnet:mainfrom Oct 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes memory allocation for expression captures by specifying an initial capacity of 1 when creating List instances, based on the observation that most expressions contain only a single capture. This avoids the default capacity of 4, reducing memory overhead.
Key changes:
- Modified List constructor calls to specify initial capacity of 1 for
transformExpressions - Added performance comments explaining the optimization rationale
rainersigwald
approved these changes
Sep 26, 2025
JanProvaznik
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
This was referenced Feb 23, 2026
Merged
Open
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
In most cases, an expression will only have one capture. We can optimize for that case and avoid allocating a size 4 array (list default) just to hold one element.
Before:

After:

This saves ~150MB
Changes Made
Testing
Notes