Add signtype to parameters #12466
Merged
Add signtype to parameters #12466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the MSBuild Azure DevOps pipeline configuration from using a variable-based signing type to a parameter-based approach. This change provides better control over code signing configuration during pipeline execution.
Key changes:
- Replace hardcoded
SignTypevariable references with a configurablesignTypeParameter - Add
signTypeParameterto pipeline parameter definitions with appropriate defaults - Update task configurations to use the new parameter instead of the variable
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| azure-pipelines/.vsts-dotnet-exp-perf.yml | Adds signTypeParameter with 'test' default and removes commented SignType variable |
| azure-pipelines/.vsts-dotnet-build-jobs.yml | Updates MicroBuildSigningPlugin task to use parameter instead of variable |
| .vsts-dotnet.yml | Adds signTypeParameter with 'real' default for production builds |
Contributor
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
Co-authored-by: Copilot <[email protected]>
JanProvaznik
approved these changes
Sep 1, 2025
SimaTian
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.