experimental suffix in exp perf build #12444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanProvaznik
force-pushed
the
exp/exp-build-name
branch
from
c2318d1 to
40f4d5e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a naming collision issue between official build packages and experimental performance build packages that was introduced in PR #12397. The solution adds a distinct "experimental" suffix to experimental builds to differentiate them from regular builds.
- Adds conditional logic to use "experimental" as the pre-release version label when building experimental packages
- Passes the IsExperimental parameter to the build process to enable the conditional logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Versions.props | Adds conditional PreReleaseVersionLabel override to use "experimental" when IsExperimental is true |
| azure-pipelines/.vsts-dotnet-build-jobs.yml | Passes IsExperimental parameter to MSBuild during the build process |
JanProvaznik
changed the title
YuliiaKovalova
approved these changes
Aug 28, 2025
SimaTian
approved these changes
Aug 28, 2025
JanProvaznik
added a commit
that referenced
this pull request
Aug 28, 2025
after #12444 VS rejects the exp package because it's a version downgrade because alphabetically `experimental` < `preview` ### Changes Made change suffix to `test` ### Testing https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/665646 ### Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
collision between package names in official build and exp perf build after split in #12397 causes package duplicate names
Changes Made
change package suffix for experimental
Testing
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12283803&view=results
Notes
I'm not sure if it's a problem for netcore infra that the official build ids can be duplicate with exp-perf builds, but this is improvement over current state for our VS use case.
We cant edit build ids freely, they have to have the default format of date+revision.