-
Notifications
You must be signed in to change notification settings - Fork 1.4k
vs16.11 onboard signing #12427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vs16.11 onboard signing #12427
Conversation
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the MSBuild pipeline signing infrastructure to use MicroBuildSigningPlugin@4 and separates the experimental pipeline from the production pipeline to improve build management and security.
Key changes:
- Updates signing plugin from MicroBuildSigningPlugin@1 to MicroBuildSigningPlugin@4 with enhanced configuration
- Creates dedicated experimental pipeline configuration for exp/* branches
- Refactors common build job logic into a reusable template
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
azure-pipelines/.vsts-dotnet-exp-perf.yml |
New experimental pipeline configuration for exp/* branches with signing validation parameter |
azure-pipelines/.vsts-dotnet-build-jobs.yml |
New template containing extracted common build job logic with updated MicroBuildSigningPlugin@4 |
.vsts-dotnet.yml |
Main pipeline refactored to use new build jobs template and exclude exp/* branches |
…com/dotnet/msbuild into dev/ykovalova/16.11_onboard_signing
JanProvaznik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exp insertion has to be updated too, so it takes bits from exp build and inserts to 16.11
done |
Fix ##12398
Use MicroBuildSigningPlugin@4 and split pipeline on prod and exp.
Exp run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12265616&view=results