Skip to content

Conversation

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Aug 26, 2025

Fix ##12398

Use MicroBuildSigningPlugin@4 and split pipeline on prod and exp.
Exp run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12265616&view=results

Copilot AI review requested due to automatic review settings August 26, 2025 13:38
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner August 26, 2025 13:38
@dotnet-policy-service
Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the MSBuild pipeline signing infrastructure to use MicroBuildSigningPlugin@4 and separates the experimental pipeline from the production pipeline to improve build management and security.

Key changes:

  • Updates signing plugin from MicroBuildSigningPlugin@1 to MicroBuildSigningPlugin@4 with enhanced configuration
  • Creates dedicated experimental pipeline configuration for exp/* branches
  • Refactors common build job logic into a reusable template

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
azure-pipelines/.vsts-dotnet-exp-perf.yml New experimental pipeline configuration for exp/* branches with signing validation parameter
azure-pipelines/.vsts-dotnet-build-jobs.yml New template containing extracted common build job logic with updated MicroBuildSigningPlugin@4
.vsts-dotnet.yml Main pipeline refactored to use new build jobs template and exclude exp/* branches

Copy link
Member

@JanProvaznik JanProvaznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exp insertion has to be updated too, so it takes bits from exp build and inserts to 16.11

@YuliiaKovalova
Copy link
Member Author

exp insertion has to be updated too, so it takes bits from exp build and inserts to 16.11

done

@GangWang01 GangWang01 merged commit 49cb985 into vs16.11 Aug 27, 2025
5 checks passed
@GangWang01 GangWang01 deleted the dev/ykovalova/16.11_onboard_signing branch August 27, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants