Revert "Avoid conhost processes for worker nodes on Windows"

[JanProvaznik]

Reverts #12356

#12356 (comment)
regresses exception counts in VS RPS

[Copilot]

Pull Request Overview

This PR reverts a previous change that avoided spawning conhost processes for worker nodes on Windows. The revert is necessary because the original optimization caused regressions in exception counts during Visual Studio RPS (Requests Per Second) testing.

• Removes the DETACHED_PROCESS flag from worker node creation on Windows
• Removes the associated constant definition and explanatory comment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Build/BackEnd/Node/NativeMethods.cs	Removes the DETACHED_PROCESS constant definition
src/Build/BackEnd/Components/Communications/NodeLauncher.cs	Removes the code that sets the DETACHED_PROCESS flag and related comment

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[YuliiaKovalova]

Can we attempt to fix it in the worker node?
In Xmake add this method

[DllImport("kernel32.dll")]
private static extern IntPtr GetConsoleWindow();

private static bool HasConsole()
{
    return GetConsoleWindow() != IntPtr.Zero;
}

and invoke it in SetConsoleUI before making any console operations?

[rainersigwald]

@YuliiaKovalova yes but I'm going to hold myself to the "revert then fix" baseline.