-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add streamlined GitHub Copilot instructions for MSBuild repository development #12339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
|
This is what I've been using locally, but I haven't gotten enough experimentation time with it to know how much it helps:
|
@copilot check it out and apply |
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Applied @rainersigwald's guidance from the previous comment. Added:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces comprehensive GitHub Copilot instructions to enhance AI-assisted development in the MSBuild repository. It provides detailed guidance for building, testing, and developing MSBuild across Windows, macOS, and Linux platforms, with emphasis on performance-first coding practices and proper development workflows.
Key changes:
- Cross-platform build and bootstrap instructions with specific timing guidance
- Performance-focused coding standards emphasizing allocation minimization and modern C# features
- Comprehensive troubleshooting section addressing common development environment issues
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…fy content, and remove network connectivity references Co-authored-by: rainersigwald <3347530+rainersigwald@users.noreply.github.com>
JanProvaznik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few edits that I think would be beneficial. I'm curious to see if this file will help the agent. I wouldn't keep this for much longer in review, we can always improve or turn it off.
Co-authored-by: Jan Provazník <janprovaznik@microsoft.com>
…ble guidance, update version examples Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Applied @rainersigwald's guidance. The instructions now include performance emphasis (minimize allocations, avoid LINQ), modern C# features preference (C# 13, collection expressions), testing requirements (xUnit with Shouldly assertions), and code style guidance. f96a492 |
This PR adds comprehensive GitHub Copilot instructions to help coding agents work effectively with the MSBuild repository. The instructions provide essential guidance for building, testing, and developing with MSBuild across Windows, macOS, and Linux platforms.
Key Features
Cross-Platform Build Support:
build.cmd) and Unix systems (build.sh)Performance and Coding Standards:
[]overnew Type[])Streamlined Development Workflow:
artifacts/bin/bootstrap/core/MSBuild.dll)Practical Troubleshooting:
The instructions have been refined based on maintainer feedback to focus on the most essential information for effective development while removing sections that add unnecessary complexity to the context window.
Fixes #12338.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.