Skip to content

Conversation

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Jul 7, 2025

Use MicroBuildSigningPlugin from arcade templates
internal run: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=11968230&view=results

  • split .vsts-dotnet.yml to prod and test pipelines

Copilot AI review requested due to automatic review settings July 7, 2025 17:10
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner July 7, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches to using the MicroBuildSigningPlugin via the shared arcade job template and removes the explicit signing and cleanup tasks.

  • Adds a job.yml template invocation with enableMicrobuild: true
  • Removes the manual MicroBuildSigningPlugin task
  • Removes the manual MicroBuildCleanup task
Comments suppressed due to low confidence (2)

.vsts-dotnet.yml:95

  • Ensure that the enableMicrobuild: true parameter in the template covers the signing conditions (e.g., SignType checks) previously handled by the explicit task; otherwise, artifacts may be signed when not intended.
      - template: /eng/common/templates-official/job/job.yml@self

Copy link
Member

@JanProvaznik JanProvaznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the internal job doesn't run and requires some approval, I saw something similar in FR, I guess just ask them to allow it?

@YuliiaKovalova YuliiaKovalova changed the title Use MicroBuildSigningPlugin from arcade templates [DO NOT MERGE] Use MicroBuildSigningPlugin from arcade templates Jul 8, 2025
@YuliiaKovalova YuliiaKovalova changed the title [DO NOT MERGE] Use MicroBuildSigningPlugin from arcade templates [DO NOT MERGE] Use MicroBuildSigningPlugin from arcade templates and split .vsts-dotnet.yml Jul 8, 2025
@YuliiaKovalova YuliiaKovalova changed the title [DO NOT MERGE] Use MicroBuildSigningPlugin from arcade templates and split .vsts-dotnet.yml Use MicroBuildSigningPlugin from arcade templates and split .vsts-dotnet.yml Jul 8, 2025
@YuliiaKovalova YuliiaKovalova self-assigned this Jul 9, 2025
@YuliiaKovalova YuliiaKovalova merged commit 52df440 into dotnet:main Jul 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants