[vs17.14] Revert change in _SplitProjectReferencesByFileExistence #12035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the AssignProjectConfiguration dependency removal for the _SplitProjectReferencesByFileExistence target to restore historical behavior and avoid customer regressions, and bumps the version prefix for a new release.
- Re-adds
DependsOnTargets="AssignProjectConfiguration"attribute to the target declaration - Updates
<VersionPrefix>from17.14.13to17.14.14for the upcoming release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Tasks/Microsoft.Common.CurrentVersion.targets | Restores DependsOnTargets="AssignProjectConfiguration" on the _SplitProjectReferencesByFileExistence target |
| eng/Versions.props | Increments <VersionPrefix> to 17.14.14 |
YuliiaKovalova
changed the title
rainersigwald
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regression caused by change #11167 in _SplitProjectReferencesByFileExistence target. The decision was made to prioritize customer stability over the technical improvement, as the widespread impact couldn't be quickly addressed by affected users.
Customer Impact
Customers experienced breaking changes in project reference handling that require modifications on their end to resolve. The impact is widespread and cannot be easily mitigated by users without targets changes on their side (e.g a custom target like described here #11923).
Regression?
Yes, introduced by change #11167.
Risk
Very Low - Reverting to previous historical behavior that was proven stable.
Changes Made
Reverted the _SplitProjectReferencesByFileExistence target changes to restore the previous historical behavior.