Use SDK from .dotnet with new resolvers #11970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses [SDK hint paths][] to tell modern SDK resolvers (.NET CLI in 10 previews, and unreleased VS versions at present) to use the SDK from the `.dotnet` folder that Arcade restores, instead of the default behavior. [hint_paths]: https://github.com/dotnet/designs/blob/238ca0202ea5df96d378a06c01960fc289aba166/accepted/2025/local-sdk-global-json.md
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR configures the .NET SDK resolver to prefer the locally restored .dotnet folder and provides a custom error message if no SDK is found.
- Add SDK hint
pathsto direct modern CLI/VS resolvers to.dotnetand fallback to host-installed SDKs - Introduce an
errorMessageto guide contributors when the SDK lookup fails
Comments suppressed due to low confidence (2)
global.json:4
- New SDK hint paths logic isn’t exercised by existing tests; consider adding a CI or unit test to verify resolution order from
.dotnetand fallback to$host$.
"paths": [ ".dotnet", "$host$" ],
global.json:5
- [nitpick] Update the project README or contributor guide to explain the new
pathsanderrorMessageproperties so users understand the custom resolution behavior and fallback instructions.
"errorMessage": "The .NET SDK could not be found, please run a command-line build with ./build.cmd."
baronfel
approved these changes
Jun 6, 2025
AR-May
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses SDK hint paths to tell modern SDK resolvers (.NET CLI in 10 previews, and unreleased VS versions at present) to use the SDK from the
.dotnetfolder that Arcade restores, instead of the default behavior.Should be silently ignored by older resolvers, so shouldn't change CI behavior.