Don't emit duplicate src files to binlog in CodeTaskFactory #11965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanProvaznik
requested changes
Jun 6, 2025
Member
JanProvaznik
left a comment
JanProvaznik
left a comment
There was a problem hiding this comment.
- please make PRs with titles that indicate what the PR does, so we can orient in PR list view, not just issue reference (e.g. copy issue title/description "Fix duplicate logging of code from CodeTaskFactories")
- the original issue asks to fix RoslynCodeTaskFactory too, please add that
- I added comments about the implementation
huulinhnguyen-dev
changed the title
huulinhnguyen-dev
changed the title
huulinhnguyen-dev
force-pushed
the
dev/huulinhnguyen/issue11884
branch
from
a8883f4 to
be1eca0
Compare
Contributor
Author
|
Hi @JanProvaznik , about the RoslynCodeTaskFactory, its already implement the logic for use the compile code from the cache, so we no need to implement in RoslynCodeTaskFactory |
GangWang01
reviewed
Jun 9, 2025
huulinhnguyen-dev
changed the title
JanProvaznik
changed the title
JanProvaznik
approved these changes
Jun 9, 2025
add logic to generate file even when it compile error Add unit test for new code changes Add unit test for the code changes Remove unused code Add unit test for code change
huulinhnguyen-dev
force-pushed
the
dev/huulinhnguyen/issue11884
branch
from
8304e82 to
d2edc20
Compare
GangWang01
reviewed
Jun 10, 2025
GangWang01
reviewed
Jun 10, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix the issue: Don't emit duplicate generated files into the binlog #11884
Context
The CodeTaskFactory was generating multiple .tmp files in the binlog for each invocation of a task, even when the task used the same source code. The goal is to emit only one .tmp file per unique task source code after its first successful compilation.
Changes Made
Added a HashSet _loggedCodeFiles to track task specifications already logged to the binlog.
Updated the logic to check _loggedCodeFiles before emitting a .tmp file, ensuring only one file is logged per unique FullTaskSpecification
Testing
Created a test project that invokes CustomTask multiple times with parameters (InputParameter="Foo" and InputParameter="Bar") via Another.proj and directly.
Verified that only one .tmp file is generated in the binlog for tasks sharing the same source code (from Import.targets), confirming duplicate suppression.
Created an additional project (Another1.proj) with a different source code (Import1.targets) to confirm two .tmp files are generated when source codes differ, validating that unique FullTaskSpecification instances produce separate files.
Notes