Remove closures from ExpandItemIntoItems #11943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses unnecessary closures and extra allocations by replacing a LINQ filter with an explicit for loop.
- Replaces LINQ filtering with a for loop to reduce allocations.
- Pre-allocates a result list to store filtered items.
src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs
Show resolved
Hide resolved
ttstanley
changed the title
rainersigwald
approved these changes
Jun 4, 2025
src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs
Show resolved
Hide resolved
SimaTian
reviewed
Jun 5, 2025
src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs
Show resolved
Hide resolved
SimaTian
approved these changes
Jun 5, 2025
Member
SimaTian
left a comment
SimaTian
left a comment
There was a problem hiding this comment.
LGTM, just please add the comment as we discussed.
…at might crop up in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Based on some traces there were some closures from a linq call without the right context. This caused extra allocations and this addresses it.
Changes Made
Instead of using linq to filter ites, just used a for loop to create a filtered list
Testing
Compared with ILSpy that there were less closures and allocations (DisplayName)
Before
After
Notes