Fix invalid substitutionGroup in Microsoft.Build.CommonTypes #11902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an invalid substitutionGroup attribute in Microsoft.Build.CommonTypes.xsd that was causing Visual Studio issues.
- Updated the substitutionGroup for the "EnableCustomCulture" element from msb:EnableCustomCulture to msb:Property.
- Bumped the VersionPrefix in eng/Versions.props from 17.14.8 to 17.14.9 to reflect the update.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd | Corrected the substitutionGroup attribute for the "EnableCustomCulture" element. |
| eng/Versions.props | Updated the VersionPrefix to reflect the new version. |
Comments suppressed due to low confidence (1)
src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd:1896
- Confirm that changing the substitutionGroup to msb:Property is consistent with the schema design across similar elements.
<xs:element name="EnableCustomCulture" type="msb:boolean" substitutionGroup="msb:Property"/>
JanProvaznik
approved these changes
May 26, 2025
surayya-MS
approved these changes
May 26, 2025
This was referenced Feb 4, 2026
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The typo in substitutionGroup in Microsoft.Build.CommonTypes causes VS issues.
Changes Made
Fix the invalid element in Microsoft.Build.CommonTypes.
Testing
Manual.