[vs16.11] Merge tag v16.11.6 #11871
Merged
[vs16.11] Merge tag v16.11.6 #11871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse headers DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior ---- #### AI description (iteration 2) #### PR Classification Bug fix #### PR Summary This pull request updates the `DownloadFile` task to avoid relying on response headers for determining the file name. - `src/Tasks/DownloadFile.cs`: Modified `TryGetFileName` method to use the request URI instead of the response headers to determine the file name. Updated method calls accordingly. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Contributor
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the version tag to v16.11.6, refactors file name extraction in DownloadFile.cs, and introduces new and updated pipeline definitions for VS insertion and OptProf.
- Updated DownloadFile.cs to pass a Uri instead of an HttpResponseMessage when determining a file name.
- Bumped VersionPrefix in Versions.props from 16.11.3 to 16.11.6.
- Added and updated Azure Pipelines YAML definitions for experimental VS insertion, official VS insertion, and optimized OptProf runs.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Tasks/DownloadFile.cs | Updated TryGetFileName to use Uri and its related XML comment; simplified file name retrieval logic. |
| eng/Versions.props | Bumped VersionPrefix to v16.11.6 while keeping AssemblyVersion unchanged. |
| azure-pipelines/vs-insertion-experimental.yml | Added an experimental pipeline definition for VS insertion. |
| azure-pipelines/vs-insertion.yml | Added a new VS insertion pipeline definition (note potential file naming correction). |
| .opt-prof.yml | Updated repository references and introduced a new parameter for test machine cleanup. |
Comments suppressed due to low confidence (3)
azure-pipelines/vs-insertion.yml:139
- Replace 'your're' with "you're" in the error message for correct spelling.
Write-Error "InsertTargetBranch is not set, this means your're not inserting from main or a valid servicing branch."
azure-pipelines/vs-insertion.yml:1
- The file name appears to contain an extra space; if unintentional, rename it to 'azure-pipelines/vs-insertion.yml' for consistency.
# Create a VS insertion (DotNet-MSBuild-Trusted -> VS) from a CI run on main or any servicing branch.
eng/Versions.props:5
- The AssemblyVersion remains at 15.1.0.0 while the VersionPrefix has been updated to 16.11.6; confirm that this versioning mismatch is intentional and acceptable for the project.
<VersionPrefix>16.11.6</VersionPrefix>
rainersigwald
approved these changes
May 22, 2025
YuliiaKovalova
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes