Skip to content

Don't autocomplete servicing insertions #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Don't autocomplete servicing insertions #11283

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9a626
Don't autocomplete servicing insertions
JanProvaznik Jan 14, 2025
acd79e9
bump version
JanProvaznik Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion azure-pipelines/vs-insertion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,16 @@ extends:
$propsValue = $props -join ";"
Write-Host "Setting InsertPackagePropsValues to '$propsValue'"
Write-Host "##vso[task.setvariable variable=InsertPackagePropsValues]$($propsValue)"

# autocomplete main
$autocomplete = "false"
if ("$(InsertTargetBranch)" -eq "main")
{
$autocomplete = "true"
}
Write-Host "Setting AutoCompleteEnabled to '$autocomplete'"
Write-Host "##vso[task.setvariable variable=AutoCompleteEnabled]$($autocomplete)"

- task: 1ES.PublishNuGet@1
displayName: 'Push MSBuild CoreXT packages'
condition: ${{ eq(parameters.SkipUploadingPackages, false) }}
Expand Down Expand Up @@ -268,6 +278,6 @@ extends:
DefaultConfigValues: $(InsertConfigValues)
InsertionReviewers: MSBuild,VS ProTools
CustomScriptExecutionCommand: $(InsertCustomScriptExecutionCommand)
AutoCompletePR: true
AutoCompletePR: $(AutoCompleteEnabled)
AutoCompleteMergeStrategy: Squash
InsertionBuildPolicy: Request Perf DDRITs