Skip to content

Add result for target stop event trace #11202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Add result for target stop event trace #11202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf11fcd
Add result for target stop event trace
JaynieBai Dec 30, 2024
221419f
Update the event Version property
JaynieBai Jan 2, 2025
5ed80ee
Handle null target result
JaynieBai Jan 3, 2025
47a994f
Merge branch 'main' into dev/jennybai/issue10975
SimaTian Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Build/BackEnd/Components/RequestBuilder/TargetBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ private async Task ProcessTargetStack(ITaskBuilder taskBuilder)
// Execute all of the tasks on this target.
MSBuildEventSource.Log.TargetStart(currentTargetEntry.Name);
await currentTargetEntry.ExecuteTarget(taskBuilder, _requestEntry, _projectLoggingContext, _cancellationToken);
MSBuildEventSource.Log.TargetStop(currentTargetEntry.Name);
MSBuildEventSource.Log.TargetStop(currentTargetEntry.Name, currentTargetEntry.Result?.ResultCode.ToString() ?? string.Empty);
}

break;
Expand Down
7 changes: 4 additions & 3 deletions src/Framework/MSBuildEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,10 +362,11 @@ public void TargetStart(string targetName)
}

/// <param name="targetName">The name of the target being executed.</param>
[Event(44, Keywords = Keywords.All | Keywords.PerformanceLog)]
public void TargetStop(string targetName)
/// <param name="result">Target stop result.</param>
[Event(44, Keywords = Keywords.All | Keywords.PerformanceLog, Version = 1)]
public void TargetStop(string targetName, string result)
{
WriteEvent(44, targetName);
WriteEvent(44, targetName, result);
}

/// <summary>
Expand Down