Always respect warning-as-error properties #10892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
reviewed
Oct 27, 2024
rainersigwald
force-pushed
the
respect-warningsnotaserrors-from-worker-nodes
branch
from
553fbc3 to
5e6038b
Compare
maridematte
approved these changes
Nov 7, 2024
Remote (built in another node) projects were not respecting MSBuildWarningsNotAsErrors configured in the projects, when the API or CLI `-warnaserror` option was enabled. Fixes dotnet#10874.
rainersigwald
force-pushed
the
respect-warningsnotaserrors-from-worker-nodes
branch
from
5e6038b to
f38f147
Compare
rainersigwald
deleted the
respect-warningsnotaserrors-from-worker-nodes
branch
|
/backport to vs17.12 |
|
Started backporting to vs17.12: https://github.com/dotnet/msbuild/actions/runs/11919226150 |
surayya-MS
added a commit
that referenced
this pull request
Nov 21, 2024
Backport of #10892 to vs17.12 Work item (Internal use): ### Summary Respect warning-as-error settings configured per-project when `-warnaserror` is passed on the command line. ### Customer Impact Suppressing warnings is unnecessarily complicated and fails for confusing reasons. ### Regression? No, this behavior is longstanding, but the severity is higher with NuGet Audit because NuGet advises configuring warning-as-warning for audit warning codes. ### Testing Automated and targeted scenario tests. ### Risk Low: makes an existing opt-in codepath default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote (built in another node) projects were not respecting MSBuildWarningsNotAsErrors configured in the projects, when the API or CLI
-warnaserroroption was enabled.Fixes #10874.