pass location information to EventArgs #10545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Build*EventArgs constructors for relevant data split IMSBuildElementLocation to file
JanKrivanek
approved these changes
Aug 22, 2024
Before
After
|
|
We should check the appearance of the |
maridematte
reviewed
Aug 23, 2024
YuliiaKovalova
approved these changes
Aug 29, 2024
I moved it to a separate ticket: #10581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10529
Context
Changes Made
split IMSBuildElementLocation to separate file and added it to Framework .dll (kept in Microsoft.Build.BackEnd namespace, that should be moved eventually if desirable #10544 )
removed location from BuildCheckResult.FormatMessage, location is logged via the filled parameters by Build*EventArgs
Testing
Notes