Skip to content

Conversation

@JanProvaznik
Copy link
Member

@JanProvaznik JanProvaznik commented Jun 18, 2024

This is a PR for the proposed WASI-Build feature spec, only documentation

WIP implementation: https://github.com/JanProvaznik/MSBuildWasm

@JanProvaznik JanProvaznik added Area: Tasks Issues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll. WIP labels Jun 18, 2024
@JanProvaznik JanProvaznik self-assigned this Jun 18, 2024
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I've got LOTS of comments here but this is great progress and I'm getting even more excited about the project. Feel free to reach out to discuss anything.

@JanProvaznik JanProvaznik changed the base branch from main to feature/wasi-tasks June 20, 2024 14:49
clarify spec, update with info about communication between host and tasks
@JanProvaznik JanProvaznik changed the title WASI-Build spec Wasm-Build spec Jul 1, 2024
@JanProvaznik JanProvaznik changed the title Wasm-Build spec Wasm/WASI tasks spec Jul 12, 2024
@JanProvaznik JanProvaznik removed the WIP label Jul 15, 2024
@JanProvaznik JanProvaznik marked this pull request as ready for review July 15, 2024 13:00
@JanProvaznik JanProvaznik changed the base branch from feature/wasi-tasks to main July 15, 2024 13:00
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some small comments to consider

@JanProvaznik JanProvaznik force-pushed the dev/janpro/wasi-tasks-spec branch from a19d9b5 to 89fe997 Compare July 17, 2024 11:23
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it!

@rainersigwald
Copy link
Member

@lambdageek @lewing y'all might be interested in this project.

format and fix WIT so it can generate bindings
@YuliiaKovalova YuliiaKovalova merged commit 0716e1c into dotnet:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Tasks Issues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants