Skip to content

Remove extra disposal #10052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Remove extra disposal #10052

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45bfe85
fix extra disposal
YuliiaKovalova Apr 22, 2024
c86b4c7
fix review comment
YuliiaKovalova Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Tasks/ManifestUtil/ManifestReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ public static Manifest ReadManifest(string manifestType, Stream input, bool pres
private static Manifest Deserialize(Stream s)
{
s.Position = 0;
using var r = new XmlTextReader(s) { DtdProcessing = DtdProcessing.Ignore };
#pragma warning disable CA2000 // Dispose objects before losing scope is suppressed because the stream will be handled in the caller
var r = new XmlTextReader(s) { DtdProcessing = DtdProcessing.Ignore };
#pragma warning restore CA2000 // Dispose objects before losing scope

do
{
Expand Down